You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by je...@apache.org on 2019/11/23 23:38:16 UTC
[pulsar] branch revert-5628-wait_client_shutdown created (now
759de7d)
This is an automated email from the ASF dual-hosted git repository.
jerrypeng pushed a change to branch revert-5628-wait_client_shutdown
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
at 759de7d Revert "Fix: Netty threads may still linger after client close (#5628)"
This branch includes the following new commits:
new 759de7d Revert "Fix: Netty threads may still linger after client close (#5628)"
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[pulsar] 01/01: Revert "Fix: Netty threads may still linger after
client close (#5628)"
Posted by je...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jerrypeng pushed a commit to branch revert-5628-wait_client_shutdown
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit 759de7dbf0db481196dda01e232f23a6c29c87e1
Author: Boyang Jerry Peng <je...@gmail.com>
AuthorDate: Sat Nov 23 15:38:08 2019 -0800
Revert "Fix: Netty threads may still linger after client close (#5628)"
This reverts commit 413aa74ed68557284d6f4502456b3bef2dbd9618.
---
.../src/main/java/org/apache/pulsar/client/impl/ConnectionPool.java | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConnectionPool.java b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConnectionPool.java
index fc41e4c..2b2f822 100644
--- a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConnectionPool.java
+++ b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConnectionPool.java
@@ -40,7 +40,6 @@ import java.util.Random;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
-import java.util.concurrent.TimeUnit;
import java.util.function.Supplier;
import org.apache.pulsar.client.api.PulsarClientException;
@@ -282,8 +281,8 @@ public class ConnectionPool implements Closeable {
@Override
public void close() throws IOException {
+ eventLoopGroup.shutdownGracefully();
dnsResolver.close();
- eventLoopGroup.shutdown();
}
private void cleanupConnection(InetSocketAddress address, int connectionKey,