You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/20 16:30:30 UTC

[GitHub] [spark] luranhe commented on a change in pull request #33399: [SPARK-36211][PYTHON] Correct typing of `udf` return value

luranhe commented on a change in pull request #33399:
URL: https://github.com/apache/spark/pull/33399#discussion_r673280518



##########
File path: python/pyspark/sql/functions.pyi
##########
@@ -359,13 +360,13 @@ def variance(col: ColumnOrName) -> Column: ...
 @overload
 def udf(
     f: Callable[..., Any], returnType: DataTypeOrString = ...
-) -> Callable[..., Column]: ...
+) -> UserDefinedFunction: ...

Review comment:
       Just took a look, should we be using `UserDefinedFunctionLike` [here](https://github.com/apache/spark/blob/0494dc90af48ce7da0625485a4dc6917a244d580/python/pyspark/sql/_typing.pyi#L56)?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org