You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/05 12:03:45 UTC

[GitHub] [skywalking] wu-sheng commented on pull request #6685: Support @Trace, @Tag and @Tags work for static methods

wu-sheng commented on pull request #6685:
URL: https://github.com/apache/skywalking/pull/6685#issuecomment-813360252


   Hi, thanks for submitting. I think there is one decision to be made. Today, we don't support to use `this.field` as tag value, so, trace/tag instance and static methods look the same. But consider those cases, they are not.
   What do you think about separating these 2 cases, and we may need to add support for `this.field` one day.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org