You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/04 03:00:30 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #32047: [SPARK-34951][INFRA][PYTHON][TESTS]Set the system encoding as UTF-8 to recover the Sphinx build in GitHub Actions
HyukjinKwon opened a new pull request #32047:
URL: https://github.com/apache/spark/pull/32047
### What changes were proposed in this pull request?
This PR proposes to set the system encoding as UTF-8. For some reasons, it looks like GitHub Actions machines changed theirs to ASCII by default. This leads to implicit encoding/decoding in Python and looks like Sphinx depends on that.
### Why are the changes needed?
To recover GItHub Actions build.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
Tested in https://github.com/apache/spark/pull/32046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32047: [SPARK-34951][INFRA][PYTHON][TESTS] Set the system encoding as UTF-8 to recover the Sphinx build in GitHub Actions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32047:
URL: https://github.com/apache/spark/pull/32047#issuecomment-812967803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32047: [SPARK-34951][INFRA][PYTHON][TESTS] Set the system encoding as UTF-8 to recover the Sphinx build in GitHub Actions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #32047:
URL: https://github.com/apache/spark/pull/32047#discussion_r606752180
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -282,6 +282,9 @@ jobs:
lint:
name: Linters, licenses, dependencies and documentation generation
runs-on: ubuntu-20.04
+ env:
+ LC_ALL: C.UTF-8
+ LANG: C.UTF-8
Review comment:
Ur, interesting. Previously, I moved this from here to line 360 because the linter is executed inside `dongjoon/apache-spark-github-action-image:20201025`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #32047: [SPARK-34951][INFRA][PYTHON][TESTS] Set the system encoding as UTF-8 to recover the Sphinx build in GitHub Actions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #32047:
URL: https://github.com/apache/spark/pull/32047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32047: [SPARK-34951][INFRA][PYTHON][TESTS] Set the system encoding as UTF-8 to recover the Sphinx build in GitHub Actions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32047:
URL: https://github.com/apache/spark/pull/32047#issuecomment-812980295
**[Test build #136889 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136889/testReport)** for PR 32047 at commit [`a9d83d6`](https://github.com/apache/spark/commit/a9d83d6cdd6400de6cc5bf4dbc5305f3f1493120).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32047: [SPARK-34951][INFRA][PYTHON][TESTS] Set the system encoding as UTF-8 to recover the Sphinx build in GitHub Actions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32047:
URL: https://github.com/apache/spark/pull/32047#issuecomment-812979165
Anyway, if this passes GA, please proceed to merge. Thank you always, @HyukjinKwon !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32047: [SPARK-34951][INFRA][PYTHON][TESTS] Set the system encoding as UTF-8 to recover the Sphinx build in GitHub Actions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32047:
URL: https://github.com/apache/spark/pull/32047#issuecomment-812987572
Merged to master, branch-3.1 and branch-3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #32047: [SPARK-34951][INFRA][PYTHON][TESTS] Set the system encoding as UTF-8 to recover the Sphinx build in GitHub Actions
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #32047:
URL: https://github.com/apache/spark/pull/32047#discussion_r606747337
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -357,8 +360,6 @@ jobs:
- name: Run documentation build
run: |
cd docs
- export LC_ALL=C.UTF-8
- export LANG=C.UTF-8
Review comment:
interesting, so export doesn't work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32047: [SPARK-34951][INFRA][PYTHON][TESTS] Set the system encoding as UTF-8 to recover the Sphinx build in GitHub Actions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32047:
URL: https://github.com/apache/spark/pull/32047#discussion_r606752195
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -357,8 +360,6 @@ jobs:
- name: Run documentation build
run: |
cd docs
- export LC_ALL=C.UTF-8
- export LANG=C.UTF-8
Review comment:
Oh it works. Problem was that we didn't set both when we run lint-python above that trigfers sphinx build ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32047: [SPARK-34951][INFRA][PYTHON][TESTS] Set the system encoding as UTF-8 to recover the Sphinx build in GitHub Actions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32047:
URL: https://github.com/apache/spark/pull/32047#issuecomment-812967813
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41466/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32047: [SPARK-34951][INFRA][PYTHON][TESTS] Set the system encoding as UTF-8 to recover the Sphinx build in GitHub Actions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32047:
URL: https://github.com/apache/spark/pull/32047#issuecomment-812961967
**[Test build #136889 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136889/testReport)** for PR 32047 at commit [`a9d83d6`](https://github.com/apache/spark/commit/a9d83d6cdd6400de6cc5bf4dbc5305f3f1493120).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32047: [SPARK-34951][INFRA][PYTHON][TESTS] Set the system encoding as UTF-8 to recover the Sphinx build in GitHub Actions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #32047:
URL: https://github.com/apache/spark/pull/32047#discussion_r606752324
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -357,8 +360,6 @@ jobs:
- name: Run documentation build
run: |
cd docs
- export LC_ALL=C.UTF-8
- export LANG=C.UTF-8
Review comment:
I guess we need this still.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32047: [SPARK-34951][INFRA][PYTHON][TESTS] Set the system encoding as UTF-8 to recover the Sphinx build in GitHub Actions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32047:
URL: https://github.com/apache/spark/pull/32047#issuecomment-812984849
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136889/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32047: [SPARK-34951][INFRA][PYTHON][TESTS] Set the system encoding as UTF-8 to recover the Sphinx build in GitHub Actions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32047:
URL: https://github.com/apache/spark/pull/32047#issuecomment-812967813
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41466/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32047: [SPARK-34951][INFRA][PYTHON][TESTS]Set the system encoding as UTF-8 to recover the Sphinx build in GitHub Actions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32047:
URL: https://github.com/apache/spark/pull/32047#issuecomment-812961900
Can you take a quick look please when you guys find some time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #32047: [SPARK-34951][INFRA][PYTHON][TESTS] Set the system encoding as UTF-8 to recover the Sphinx build in GitHub Actions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #32047:
URL: https://github.com/apache/spark/pull/32047#issuecomment-812979165
Anyway, if this passes GA, please proceed to merge. Thank you always, @HyukjinKwon !
(I didn't take a look at the failure in depth)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32047: [SPARK-34951][INFRA][PYTHON][TESTS]Set the system encoding as UTF-8 to recover the Sphinx build in GitHub Actions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32047:
URL: https://github.com/apache/spark/pull/32047#issuecomment-812961967
**[Test build #136889 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136889/testReport)** for PR 32047 at commit [`a9d83d6`](https://github.com/apache/spark/commit/a9d83d6cdd6400de6cc5bf4dbc5305f3f1493120).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32047: [SPARK-34951][INFRA][PYTHON][TESTS] Set the system encoding as UTF-8 to recover the Sphinx build in GitHub Actions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32047:
URL: https://github.com/apache/spark/pull/32047#issuecomment-812984849
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136889/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org