[GitHub] [spark] HyukjinKwon commented on a change in pull request #28494: [SPARK-31456][CORE] Fix shutdown hook priority edge cases

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #28494:
URL: https://github.com/apache/spark/pull/28494#discussion_r422906328



##########
File path: core/src/main/scala/org/apache/spark/util/ShutdownHookManager.scala
##########
@@ -209,9 +209,7 @@ private [util] class SparkShutdownHookManager {
 private class SparkShutdownHook(private val priority: Int, hook: () => Unit)
   extends Comparable[SparkShutdownHook] {
 
-  override def compareTo(other: SparkShutdownHook): Int = {
-    other.priority - priority

Review comment:
       Yeah, I don't think this affects any external case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org