You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "haridsv (via GitHub)" <gi...@apache.org> on 2025/09/04 13:52:18 UTC
[PR] HBASE-29558: Fix for TestShellNoCluster along with code refactoring and cleanup (#7256) [hbase]
haridsv opened a new pull request, #7274:
URL: https://github.com/apache/hbase/pull/7274
This is a cherry-pick of 5b4efe69953898750e09008634ef4d584649606e from master with the following changes:
- Reverted the change admin test, adding back the dedicated driver and renaming the ruby test file.
- Removed BaseTestShell as it is no longer needed after serving the requirement of admin test via its own driver
- Minor tweaks needed for local changes such as a new variant for setUpJRubyRuntime()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29558: Fix for TestShellNoCluster along with code refactoring and cleanup (#7256) [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #7274:
URL: https://github.com/apache/hbase/pull/7274#issuecomment-3253987893
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 54s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 49s | | branch-2 passed |
| +1 :green_heart: | compile | 0m 16s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 12s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 5m 31s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 30s | | the patch passed |
| +1 :green_heart: | compile | 0m 15s | | the patch passed |
| +1 :green_heart: | javac | 0m 15s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 10s | | the patch passed |
| +1 :green_heart: | shadedjars | 5m 28s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 6m 53s | | hbase-shell in the patch passed. |
| | | 26m 11s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/7274 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 110261baa924 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / b562b5dc56f916c01e9c4503c4abb51c9ce4d017 |
| Default Java | Temurin-1.8.0_412-b08 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/1/testReport/ |
| Max. process+thread count | 1530 (vs. ulimit of 30000) |
| modules | C: hbase-shell U: hbase-shell |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/1/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29558: Fix for TestShellNoCluster along with code refactoring and cleanup (#7256) [hbase]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani merged PR #7274:
URL: https://github.com/apache/hbase/pull/7274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29558: Fix for TestShellNoCluster along with code refactoring and cleanup (#7256) [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #7274:
URL: https://github.com/apache/hbase/pull/7274#issuecomment-3254004663
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 1m 6s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 11s | | branch-2 passed |
| +1 :green_heart: | compile | 0m 17s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 12s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 6m 49s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 10s | | the patch passed |
| +1 :green_heart: | compile | 0m 16s | | the patch passed |
| +1 :green_heart: | javac | 0m 16s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 10s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 42s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 6m 49s | | hbase-shell in the patch passed. |
| | | 31m 5s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/7274 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux e6251716c332 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / b562b5dc56f916c01e9c4503c4abb51c9ce4d017 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/1/testReport/ |
| Max. process+thread count | 1635 (vs. ulimit of 30000) |
| modules | C: hbase-shell U: hbase-shell |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/1/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29558: Fix for TestShellNoCluster along with code refactoring and cleanup (#7256) [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #7274:
URL: https://github.com/apache/hbase/pull/7274#issuecomment-3254427187
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 52s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 49s | | branch-2 passed |
| +1 :green_heart: | compile | 0m 19s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 13s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 7m 40s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 41s | | the patch passed |
| +1 :green_heart: | compile | 0m 19s | | the patch passed |
| +1 :green_heart: | javac | 0m 19s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 12s | | the patch passed |
| +1 :green_heart: | shadedjars | 7m 36s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 6m 51s | | hbase-shell in the patch passed. |
| | | 32m 40s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/7274 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 3eb9ec94534c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / cac1128ef2da847b3c93566ec70d3e5f7b0543b0 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/2/testReport/ |
| Max. process+thread count | 1646 (vs. ulimit of 30000) |
| modules | C: hbase-shell U: hbase-shell |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/2/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29558: Fix for TestShellNoCluster along with code refactoring and cleanup (#7256) [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #7274:
URL: https://github.com/apache/hbase/pull/7274#issuecomment-3254458396
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 1m 11s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 19s | | branch-2 passed |
| +1 :green_heart: | compile | 0m 36s | | branch-2 passed |
| +1 :green_heart: | checkstyle | 0m 13s | | branch-2 passed |
| +1 :green_heart: | spotbugs | 0m 0s | | branch-2 passed |
| +1 :green_heart: | spotless | 1m 13s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 36s | | the patch passed |
| +1 :green_heart: | compile | 0m 33s | | the patch passed |
| -0 :warning: | javac | 0m 33s | [/results-compile-javac-hbase-shell.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/2/artifact/yetus-general-check/output/results-compile-javac-hbase-shell.txt) | hbase-shell generated 8 new + 0 unchanged - 0 fixed = 8 total (was 0) |
| -0 :warning: | blanks | 0m 0s | [/blanks-eol.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/2/artifact/yetus-general-check/output/blanks-eol.txt) | The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | checkstyle | 0m 14s | | the patch passed |
| -0 :warning: | rubocop | 0m 56s | [/results-rubocop.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/2/artifact/yetus-general-check/output/results-rubocop.txt) | The patch generated 24 new + 412 unchanged - 68 fixed = 436 total (was 480) |
| +1 :green_heart: | spotbugs | 0m 0s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 25m 4s | | Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 1m 0s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 13s | | The patch does not generate ASF License warnings. |
| | | 46m 22s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/7274 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless rubocop |
| uname | Linux 2612bd4df759 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / cac1128ef2da847b3c93566ec70d3e5f7b0543b0 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Max. process+thread count | 77 (vs. ulimit of 30000) |
| modules | C: hbase-shell U: hbase-shell |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/2/console |
| versions | git=2.34.1 maven=3.9.8 rubocop=1.37.1 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29558: Fix for TestShellNoCluster along with code refactoring and cleanup (#7256) [hbase]
Posted by "haridsv (via GitHub)" <gi...@apache.org>.
haridsv commented on PR #7274:
URL: https://github.com/apache/hbase/pull/7274#issuecomment-3253866049
@NihalJain Could you please review?
**Here are the stats before the cerry-pick:**
Test run output
```
$ time mvn -pl hbase-shell -Pjacoco verify -PrunAllTests
...
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.client.TestTableShell
[INFO] Running org.apache.hadoop.hbase.client.TestQuotasShell
[INFO] Running org.apache.hadoop.hbase.client.TestRSGroupShell
[INFO] Running org.apache.hadoop.hbase.client.TestAdminShell
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.952 s - in org.apache.hadoop.hbase.client.TestRSGroupShell
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 38.398 s - in org.apache.hadoop.hbase.client.TestTableShell
[INFO] Running org.apache.hadoop.hbase.client.TestShellNoCluster
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.412 s - in org.apache.hadoop.hbase.client.TestShellNoCluster
[INFO] Running org.apache.hadoop.hbase.client.TestReplicationShell
[INFO] Running org.apache.hadoop.hbase.client.TestChangeSftShell
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 15.647 s - in org.apache.hadoop.hbase.client.TestChangeSftShell
[INFO] Running org.apache.hadoop.hbase.client.TestShell
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 48.49 s - in org.apache.hadoop.hbase.client.TestShell
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 155.552 s - in org.apache.hadoop.hbase.client.TestAdminShell
[INFO] Running org.apache.hadoop.hbase.client.TestAdminShell2
[INFO] Running org.apache.hadoop.hbase.client.TestListTablesShell
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.88 s - in org.apache.hadoop.hbase.client.TestListTablesShell
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 187.421 s - in org.apache.hadoop.hbase.client.TestReplicationShell
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 158.604 s - in org.apache.hadoop.hbase.client.TestAdminShell2
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 357.209 s - in org.apache.hadoop.hbase.client.TestQuotasShell
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0
...
real 6m55.766s
user 15m55.155s
sys 5m7.509s
```
Assertion counts (total 1663):
```
$ grep -E '\d+ tests, \d+ assertions' ~/src/apache/hbase/hbase-shell/target/surefire-reports/*-output.txt
/Users/hdara/src/apache/hbase/hbase-shell/target/surefire-reports/org.apache.hadoop.hbase.client.TestAdminShell-output.txt:87 tests, 224 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
/Users/hdara/src/apache/hbase/hbase-shell/target/surefire-reports/org.apache.hadoop.hbase.client.TestAdminShell2-output.txt:36 tests, 70 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
/Users/hdara/src/apache/hbase/hbase-shell/target/surefire-reports/org.apache.hadoop.hbase.client.TestChangeSftShell-output.txt:2 tests, 2 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
/Users/hdara/src/apache/hbase/hbase-shell/target/surefire-reports/org.apache.hadoop.hbase.client.TestListTablesShell-output.txt:2 tests, 2 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
/Users/hdara/src/apache/hbase/hbase-shell/target/surefire-reports/org.apache.hadoop.hbase.client.TestQuotasShell-output.txt:16 tests, 62 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
/Users/hdara/src/apache/hbase/hbase-shell/target/surefire-reports/org.apache.hadoop.hbase.client.TestReplicationShell-output.txt:32 tests, 330 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
/Users/hdara/src/apache/hbase/hbase-shell/target/surefire-reports/org.apache.hadoop.hbase.client.TestRSGroupShell-output.txt:6 tests, 44 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
/Users/hdara/src/apache/hbase/hbase-shell/target/surefire-reports/org.apache.hadoop.hbase.client.TestShell-output.txt:415 tests, 669 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
/Users/hdara/src/apache/hbase/hbase-shell/target/surefire-reports/org.apache.hadoop.hbase.client.TestTableShell-output.txt:86 tests, 260 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
```
Loaded tests (total 21):
```
$ sed -En -e "s/.*loading test file '(.*)'\./\1/p" ~/src/apache/hbase/hbase-shell/target/surefire-reports/*-output.txt
admin_test.rb
admin2_test.rb
sftchange_shell_test.rb
list_tables_test.rb
quotas_test.rb
replication_admin_test.rb
rsgroup_shell_test.rb
balancer_utils_test.rb
hbase_test.rb
security_admin_test.rb
taskmonitor_test.rb
visibility_labels_admin_test.rb
commands_test.rb
converter_test.rb
formatter_test.rb
list_locks_test.rb
list_procedures_test.rb
noninteractive_test.rb
sftchange_shell_test.rb
shell_test.rb
table_test.rb
```
**Here are the stats after the cerry-pick:**
```
$ time mvn -pl hbase-shell -Pjacoco verify -PrunAllTests
...
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.client.TestTableShell
[INFO] Running org.apache.hadoop.hbase.client.TestQuotasShell
[INFO] Running org.apache.hadoop.hbase.client.TestAdminShell
[INFO] Running org.apache.hadoop.hbase.client.TestRSGroupShell
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 84.66 s - in org.apache.hadoop.hbase.client.TestRSGroupShell
[INFO] Running org.apache.hadoop.hbase.client.TestShellNoCluster
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 91.6 s - in org.apache.hadoop.hbase.client.TestTableShell
[INFO] Running org.apache.hadoop.hbase.client.TestReplicationShell
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.315 s - in org.apache.hadoop.hbase.client.TestShellNoCluster
[INFO] Running org.apache.hadoop.hbase.client.TestShell
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 217.139 s - in org.apache.hadoop.hbase.client.TestAdminShell
[INFO] Running org.apache.hadoop.hbase.client.TestListTablesShell
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 42.776 s - in org.apache.hadoop.hbase.client.TestListTablesShell
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 224.557 s - in org.apache.hadoop.hbase.client.TestReplicationShell
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 228.493 s - in org.apache.hadoop.hbase.client.TestShell
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 397.424 s - in org.apache.hadoop.hbase.client.TestQuotasShell
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
...
real 6m54.746s
user 16m39.878s
sys 5m5.749s
```
Assertion counts (total: 1711)
```
$ grep -E '\d+ tests, \d+ assertions' ~/src/apache/hbase/hbase-shell/target/surefire-reports/*-output.txt
/Users/hdara/src/apache/hbase/hbase-shell/target/surefire-reports/org.apache.hadoop.hbase.client.TestAdminShell-output.txt:87 tests, 224 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
/Users/hdara/src/apache/hbase/hbase-shell/target/surefire-reports/org.apache.hadoop.hbase.client.TestListTablesShell-output.txt:2 tests, 2 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
/Users/hdara/src/apache/hbase/hbase-shell/target/surefire-reports/org.apache.hadoop.hbase.client.TestQuotasShell-output.txt:16 tests, 62 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
/Users/hdara/src/apache/hbase/hbase-shell/target/surefire-reports/org.apache.hadoop.hbase.client.TestReplicationShell-output.txt:32 tests, 330 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
/Users/hdara/src/apache/hbase/hbase-shell/target/surefire-reports/org.apache.hadoop.hbase.client.TestRSGroupShell-output.txt:6 tests, 44 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
/Users/hdara/src/apache/hbase/hbase-shell/target/surefire-reports/org.apache.hadoop.hbase.client.TestShell-output.txt:451 tests, 739 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
/Users/hdara/src/apache/hbase/hbase-shell/target/surefire-reports/org.apache.hadoop.hbase.client.TestShellNoCluster-output.txt:8 tests, 50 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
/Users/hdara/src/apache/hbase/hbase-shell/target/surefire-reports/org.apache.hadoop.hbase.client.TestTableShell-output.txt:86 tests, 260 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
```
Loaded tests (total: 23):
```
$ sed -En -e "s/.*loading test file '(.*)'\./\1/p" ~/src/apache/hbase/hbase-shell/target/surefire-reports/*-output.txt
admin_test.rb
list_tables_test.rb
quotas_test.rb
replication_admin_test.rb
rsgroup_shell_test.rb
admin2_test_cluster.rb
balancer_utils_test_cluster.rb
hbase_test_cluster.rb
security_admin_test_cluster.rb
taskmonitor_test_cluster.rb
visibility_labels_admin_test_cluster.rb
commands_test_cluster.rb
converter_test_cluster.rb
formatter_test_cluster.rb
general_test_cluster.rb
list_locks_test_cluster.rb
list_procedures_test_cluster.rb
noninteractive_test_cluster.rb
sftchange_test_cluster.rb
connection_test_no_cluster.rb
list_regions_test_no_cluster.rb
quotas_test_no_cluster.rb
table_test.rb
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29558: Fix for TestShellNoCluster along with code refactoring and cleanup (#7256) [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #7274:
URL: https://github.com/apache/hbase/pull/7274#issuecomment-3253993633
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 50s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 12s | | branch-2 passed |
| +1 :green_heart: | compile | 0m 17s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 12s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 6m 19s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 59s | | the patch passed |
| +1 :green_heart: | compile | 0m 17s | | the patch passed |
| +1 :green_heart: | javac | 0m 17s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 11s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 19s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 6m 46s | | hbase-shell in the patch passed. |
| | | 28m 31s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/7274 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 6af4cd223ea0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / b562b5dc56f916c01e9c4503c4abb51c9ce4d017 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/1/testReport/ |
| Max. process+thread count | 1632 (vs. ulimit of 30000) |
| modules | C: hbase-shell U: hbase-shell |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/1/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29558: Fix for TestShellNoCluster along with code refactoring and cleanup (#7256) [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #7274:
URL: https://github.com/apache/hbase/pull/7274#issuecomment-3254000866
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 51s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 34s | | branch-2 passed |
| +1 :green_heart: | compile | 0m 26s | | branch-2 passed |
| +1 :green_heart: | checkstyle | 0m 10s | | branch-2 passed |
| +1 :green_heart: | spotbugs | 0m 0s | | branch-2 passed |
| +1 :green_heart: | spotless | 0m 50s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 3s | | the patch passed |
| +1 :green_heart: | compile | 0m 18s | | the patch passed |
| -0 :warning: | javac | 0m 18s | [/results-compile-javac-hbase-shell.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/1/artifact/yetus-general-check/output/results-compile-javac-hbase-shell.txt) | hbase-shell generated 8 new + 0 unchanged - 0 fixed = 8 total (was 0) |
| -0 :warning: | blanks | 0m 0s | [/blanks-eol.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/1/artifact/yetus-general-check/output/blanks-eol.txt) | The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| -0 :warning: | checkstyle | 0m 9s | [/results-checkstyle-hbase-shell.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/1/artifact/yetus-general-check/output/results-checkstyle-hbase-shell.txt) | hbase-shell: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| -0 :warning: | rubocop | 0m 52s | [/results-rubocop.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/1/artifact/yetus-general-check/output/results-rubocop.txt) | The patch generated 24 new + 412 unchanged - 68 fixed = 436 total (was 480) |
| +1 :green_heart: | spotbugs | 0m 0s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 17m 0s | | Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0. |
| -1 :x: | spotless | 0m 40s | | patch has 21 errors when running spotless:check, run spotless:apply to fix. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 11s | | The patch does not generate ASF License warnings. |
| | | 30m 1s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/7274 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless rubocop |
| uname | Linux fe9aff23ac22 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / b562b5dc56f916c01e9c4503c4abb51c9ce4d017 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/1/artifact/yetus-general-check/output/patch-spotless.txt |
| Max. process+thread count | 77 (vs. ulimit of 30000) |
| modules | C: hbase-shell U: hbase-shell |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/1/console |
| versions | git=2.34.1 maven=3.9.8 rubocop=1.37.1 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29558: Fix for TestShellNoCluster along with code refactoring and cleanup (#7256) [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #7274:
URL: https://github.com/apache/hbase/pull/7274#issuecomment-3254395595
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 59s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 7s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 17s | | branch-2 passed |
| +1 :green_heart: | compile | 0m 19s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 14s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 6m 48s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 57s | | the patch passed |
| +1 :green_heart: | compile | 0m 19s | | the patch passed |
| +1 :green_heart: | javac | 0m 19s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 12s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 34s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 7m 13s | | hbase-shell in the patch passed. |
| | | 29m 55s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/7274 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 1828d7977708 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / cac1128ef2da847b3c93566ec70d3e5f7b0543b0 |
| Default Java | Temurin-1.8.0_412-b08 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/2/testReport/ |
| Max. process+thread count | 1528 (vs. ulimit of 30000) |
| modules | C: hbase-shell U: hbase-shell |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/2/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29558: Fix for TestShellNoCluster along with code refactoring and cleanup (#7256) [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #7274:
URL: https://github.com/apache/hbase/pull/7274#issuecomment-3254407636
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 49s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 42s | | branch-2 passed |
| +1 :green_heart: | compile | 0m 20s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 10s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 7m 49s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 43s | | the patch passed |
| +1 :green_heart: | compile | 0m 20s | | the patch passed |
| +1 :green_heart: | javac | 0m 20s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 12s | | the patch passed |
| +1 :green_heart: | shadedjars | 8m 0s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 6m 54s | | hbase-shell in the patch passed. |
| | | 33m 4s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/7274 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux e56ac5af1ea8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / cac1128ef2da847b3c93566ec70d3e5f7b0543b0 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/2/testReport/ |
| Max. process+thread count | 1655 (vs. ulimit of 30000) |
| modules | C: hbase-shell U: hbase-shell |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/2/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29558: Fix for TestShellNoCluster along with code refactoring and cleanup (#7256) [hbase]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #7274:
URL: https://github.com/apache/hbase/pull/7274#issuecomment-3254896754
@haridsv I just realized on the master branch PR also we had similar javadoc warnings https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/2/artifact/yetus-general-check/output/results-compile-javac-hbase-shell.txt
blank https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7274/2/artifact/yetus-general-check/output/blanks-eol.txt
Let's see if we can make addendum while I merge this PR and backport to other 2.x branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org