[httpcomponents-core] branch 5.1.x updated: Don't change conn flow control window based on remote SETTINGS

[ol...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

olegk pushed a commit to branch 5.1.x
in repository https://gitbox.apache.org/repos/asf/httpcomponents-core.git


The following commit(s) were added to refs/heads/5.1.x by this push:
     new f1eb8d6  Don't change conn flow control window based on remote SETTINGS
f1eb8d6 is described below

commit f1eb8d612a25f4915ec7238b6209fa25d6b5c0b3
Author: Ryan Schmitt <ry...@amazon.com>
AuthorDate: Tue May 18 11:58:46 2021 -0700

    Don't change conn flow control window based on remote SETTINGS
    
    From RFC7540 §6.9.2:
    
    > The connection flow-control window can only be changed using
    > WINDOW_UPDATE frames.
---
 .../org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java  | 1 -
 1 file changed, 1 deletion(-)

diff --git a/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java b/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java
index 1b3774c..6229b07 100644
--- a/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java
+++ b/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java
@@ -1199,7 +1199,6 @@ abstract class AbstractH2StreamMultiplexer implements Identifiable, HttpConnecti
         initOutputWinSize = remoteConfig.getInitialWindowSize();
 
         if (delta != 0) {
-            updateOutputWindow(0, connOutputWindow, delta);
             if (!streamMap.isEmpty()) {
                 for (final Iterator<Map.Entry<Integer, H2Stream>> it = streamMap.entrySet().iterator(); it.hasNext(); ) {
                     final Map.Entry<Integer, H2Stream> entry = it.next();