You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Diogo (JIRA)" <ji...@apache.org> on 2010/09/17 18:02:34 UTC
[jira] Created: (ZOOKEEPER-874) FileTxnSnapLog.restore does not
call listener
FileTxnSnapLog.restore does not call listener
---------------------------------------------
Key: ZOOKEEPER-874
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-874
Project: Zookeeper
Issue Type: Bug
Components: leaderElection
Reporter: Diogo
Priority: Trivial
FileTxnSnapLog.restore() does not call listener passed as parameter. The result is that the commitLogs list is empty. When a follower connects to the leader, the leader is forced to send a snapshot to the follower instead of a couple of requests and commits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-874) FileTxnSnapLog.restore does not
call listener
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930263#action_12930263 ]
Hadoop QA commented on ZOOKEEPER-874:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12455142/ZOOKEEPER-874.patch
against trunk revision 1033155.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/11//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/11//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/11//console
This message is automatically generated.
> FileTxnSnapLog.restore does not call listener
> ---------------------------------------------
>
> Key: ZOOKEEPER-874
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-874
> Project: Zookeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.1
> Reporter: Diogo
> Assignee: Diogo
> Priority: Trivial
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-874.patch
>
>
> FileTxnSnapLog.restore() does not call listener passed as parameter. The result is that the commitLogs list is empty. When a follower connects to the leader, the leader is forced to send a snapshot to the follower instead of a couple of requests and commits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-874) FileTxnSnapLog.restore does not
call listener
Posted by "Diogo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Diogo updated ZOOKEEPER-874:
----------------------------
Status: Patch Available (was: Open)
Affects Version/s: 3.3.1
Fix Version/s: 3.4.0
> FileTxnSnapLog.restore does not call listener
> ---------------------------------------------
>
> Key: ZOOKEEPER-874
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-874
> Project: Zookeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.1
> Reporter: Diogo
> Priority: Trivial
> Fix For: 3.4.0
>
>
> FileTxnSnapLog.restore() does not call listener passed as parameter. The result is that the commitLogs list is empty. When a follower connects to the leader, the leader is forced to send a snapshot to the follower instead of a couple of requests and commits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-874) FileTxnSnapLog.restore does not
call listener
Posted by "Diogo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Diogo updated ZOOKEEPER-874:
----------------------------
Attachment: (was: commitlog-listener.patch)
> FileTxnSnapLog.restore does not call listener
> ---------------------------------------------
>
> Key: ZOOKEEPER-874
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-874
> Project: Zookeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.1
> Reporter: Diogo
> Priority: Trivial
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-874.patch
>
>
> FileTxnSnapLog.restore() does not call listener passed as parameter. The result is that the commitLogs list is empty. When a follower connects to the leader, the leader is forced to send a snapshot to the follower instead of a couple of requests and commits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-874) FileTxnSnapLog.restore does not
call listener
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12911065#action_12911065 ]
Flavio Junqueira commented on ZOOKEEPER-874:
--------------------------------------------
The patch is indeed trivial, but I was wondering if we could write a unit test to verify that it is effective in the case you have identified, Diogo.
> FileTxnSnapLog.restore does not call listener
> ---------------------------------------------
>
> Key: ZOOKEEPER-874
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-874
> Project: Zookeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.1
> Reporter: Diogo
> Priority: Trivial
> Fix For: 3.4.0
>
> Attachments: commitlog-listener.patch
>
>
> FileTxnSnapLog.restore() does not call listener passed as parameter. The result is that the commitLogs list is empty. When a follower connects to the leader, the leader is forced to send a snapshot to the follower instead of a couple of requests and commits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-874) FileTxnSnapLog.restore does not
call listener
Posted by "Diogo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Diogo updated ZOOKEEPER-874:
----------------------------
Attachment: commitlog-listener.patch
> FileTxnSnapLog.restore does not call listener
> ---------------------------------------------
>
> Key: ZOOKEEPER-874
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-874
> Project: Zookeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.1
> Reporter: Diogo
> Priority: Trivial
> Fix For: 3.4.0
>
> Attachments: commitlog-listener.patch
>
>
> FileTxnSnapLog.restore() does not call listener passed as parameter. The result is that the commitLogs list is empty. When a follower connects to the leader, the leader is forced to send a snapshot to the follower instead of a couple of requests and commits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-874) FileTxnSnapLog.restore does not
call listener
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-874:
--------------------------------------
Assignee: Diogo
> FileTxnSnapLog.restore does not call listener
> ---------------------------------------------
>
> Key: ZOOKEEPER-874
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-874
> Project: Zookeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.1
> Reporter: Diogo
> Assignee: Diogo
> Priority: Trivial
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-874.patch
>
>
> FileTxnSnapLog.restore() does not call listener passed as parameter. The result is that the commitLogs list is empty. When a follower connects to the leader, the leader is forced to send a snapshot to the follower instead of a couple of requests and commits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-874) FileTxnSnapLog.restore does not
call listener
Posted by "Diogo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Diogo updated ZOOKEEPER-874:
----------------------------
Attachment: ZOOKEEPER-874.patch
The same as before but now with correct indentation and filename.
> FileTxnSnapLog.restore does not call listener
> ---------------------------------------------
>
> Key: ZOOKEEPER-874
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-874
> Project: Zookeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.1
> Reporter: Diogo
> Priority: Trivial
> Fix For: 3.4.0
>
> Attachments: commitlog-listener.patch, ZOOKEEPER-874.patch
>
>
> FileTxnSnapLog.restore() does not call listener passed as parameter. The result is that the commitLogs list is empty. When a follower connects to the leader, the leader is forced to send a snapshot to the follower instead of a couple of requests and commits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.