[jira] [Comment Edited] (BEAM-2714) ParDo.getAdditionalInputs() return the input of View.CreatePCollectionView instead of output.

["Pei He (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111016#comment-16111016 ] 

Pei He edited comment on BEAM-2714 at 8/2/17 2:37 PM:
------------------------------------------------------

I use TransformHierarchy.Node getInputs() and getOutputs() to setup this diagram:
!view-tag.png|thumbnail!

The marked edge is wrong.


was (Author: peihe0@gmail.com):
I use TransformHierarchy.Node getInputs() and getOutputs() to setup this diagram.
The marked edge is wrong.

> ParDo.getAdditionalInputs() return the input of View.CreatePCollectionView instead of output.
> ---------------------------------------------------------------------------------------------
>
>                 Key: BEAM-2714
>                 URL: https://issues.apache.org/jira/browse/BEAM-2714
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Pei He
>            Assignee: Thomas Groh
>            Priority: Critical
>         Attachments: view-tag.png
>
>
> For example, input-pc -> View.AsIterable -> view.out -> ParDo
> getInputs() in TransformHierarchy.Node for ParDo will return input-pc instead of view.out.
> I think the code here should make sure the output of view is returned:
> https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/values/PCollectionViews.java#L147



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)