You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Brian Wickman <wi...@apache.org> on 2014/10/04 01:19:52 UTC
Review Request 26333: Add exit status contract between thermos runner
and aurora executor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26333/
-----------------------------------------------------------
Review request for Aurora, Joe Smith and Kevin Sweeney.
Bugs: AURORA-175
https://issues.apache.org/jira/browse/AURORA-175
Repository: aurora
Description
-------
Adds an exit status contract between the ThermosTaskRunner and the thermos_runner.pex so that we can discriminate between losses / failures.
Diffs
-----
src/main/python/apache/aurora/executor/BUILD 5f0ef7c12479fe2bbdebc3dacdd6ce5aa4910413
src/main/python/apache/aurora/executor/thermos_runner.py 396753e0f95ce1342dba05ea1897a6842e6547df
src/main/python/apache/aurora/executor/thermos_statuses.py PRE-CREATION
src/main/python/apache/aurora/executor/thermos_task_runner.py 7b346e253677ee9b42c57782f7f67ff63b6a0083
src/test/python/apache/aurora/executor/test_thermos_task_runner.py 8e4042b29dce8a815c5995b9e2701c95fe3f034b
Diff: https://reviews.apache.org/r/26333/diff/
Testing
-------
Added tests. Refers to Process.UnknownUserError which is added in https://reviews.apache.org/r/25972/ but not available here.
Thanks,
Brian Wickman
Re: Review Request 26333: Add exit status contract between thermos
runner and aurora executor.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26333/#review55412
-----------------------------------------------------------
src/main/python/apache/aurora/executor/thermos_runner.py
<https://reviews.apache.org/r/26333/#comment95768>
Should emit a stack trace here.
- Kevin Sweeney
On Oct. 3, 2014, 4:19 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26333/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 4:19 p.m.)
>
>
> Review request for Aurora, Joe Smith and Kevin Sweeney.
>
>
> Bugs: AURORA-175
> https://issues.apache.org/jira/browse/AURORA-175
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adds an exit status contract between the ThermosTaskRunner and the thermos_runner.pex so that we can discriminate between losses / failures.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/BUILD 5f0ef7c12479fe2bbdebc3dacdd6ce5aa4910413
> src/main/python/apache/aurora/executor/thermos_runner.py 396753e0f95ce1342dba05ea1897a6842e6547df
> src/main/python/apache/aurora/executor/thermos_statuses.py PRE-CREATION
> src/main/python/apache/aurora/executor/thermos_task_runner.py 7b346e253677ee9b42c57782f7f67ff63b6a0083
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py 8e4042b29dce8a815c5995b9e2701c95fe3f034b
>
> Diff: https://reviews.apache.org/r/26333/diff/
>
>
> Testing
> -------
>
> Added tests. Refers to Process.UnknownUserError which is added in https://reviews.apache.org/r/25972/ but not available here.
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 26333: Add exit status contract between thermos
runner and aurora executor.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26333/#review55751
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Oct. 6, 2014, 11:12 a.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26333/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2014, 11:12 a.m.)
>
>
> Review request for Aurora, Joe Smith and Kevin Sweeney.
>
>
> Bugs: AURORA-175
> https://issues.apache.org/jira/browse/AURORA-175
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adds an exit status contract between the ThermosTaskRunner and the thermos_runner.pex so that we can discriminate between losses / failures.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/BUILD 5f0ef7c12479fe2bbdebc3dacdd6ce5aa4910413
> src/main/python/apache/aurora/executor/thermos_runner.py 396753e0f95ce1342dba05ea1897a6842e6547df
> src/main/python/apache/aurora/executor/thermos_statuses.py PRE-CREATION
> src/main/python/apache/aurora/executor/thermos_task_runner.py 7b346e253677ee9b42c57782f7f67ff63b6a0083
> src/test/python/apache/aurora/executor/test_thermos_executor.py f6ca4dfd0fd262361709361c48c93799837e0a54
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py 8e4042b29dce8a815c5995b9e2701c95fe3f034b
>
> Diff: https://reviews.apache.org/r/26333/diff/
>
>
> Testing
> -------
>
> Added tests. Refers to Process.UnknownUserError which is added in https://reviews.apache.org/r/25972/ but not available here.
>
> Update: ran build-support/jenkins/build.sh after the merge of 25972 and it passed.
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 26333: Add exit status contract between thermos
runner and aurora executor.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26333/#review56446
-----------------------------------------------------------
Ship it!
Ship It!
- Joe Smith
On Oct. 6, 2014, 11:12 a.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26333/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2014, 11:12 a.m.)
>
>
> Review request for Aurora, Joe Smith and Kevin Sweeney.
>
>
> Bugs: AURORA-175
> https://issues.apache.org/jira/browse/AURORA-175
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adds an exit status contract between the ThermosTaskRunner and the thermos_runner.pex so that we can discriminate between losses / failures.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/BUILD 5f0ef7c12479fe2bbdebc3dacdd6ce5aa4910413
> src/main/python/apache/aurora/executor/thermos_runner.py 396753e0f95ce1342dba05ea1897a6842e6547df
> src/main/python/apache/aurora/executor/thermos_statuses.py PRE-CREATION
> src/main/python/apache/aurora/executor/thermos_task_runner.py 7b346e253677ee9b42c57782f7f67ff63b6a0083
> src/test/python/apache/aurora/executor/test_thermos_executor.py f6ca4dfd0fd262361709361c48c93799837e0a54
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py 8e4042b29dce8a815c5995b9e2701c95fe3f034b
>
> Diff: https://reviews.apache.org/r/26333/diff/
>
>
> Testing
> -------
>
> Added tests. Refers to Process.UnknownUserError which is added in https://reviews.apache.org/r/25972/ but not available here.
>
> Update: ran build-support/jenkins/build.sh after the merge of 25972 and it passed.
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 26333: Add exit status contract between thermos
runner and aurora executor.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26333/
-----------------------------------------------------------
(Updated Oct. 6, 2014, 6:12 p.m.)
Review request for Aurora, Joe Smith and Kevin Sweeney.
Bugs: AURORA-175
https://issues.apache.org/jira/browse/AURORA-175
Repository: aurora
Description
-------
Adds an exit status contract between the ThermosTaskRunner and the thermos_runner.pex so that we can discriminate between losses / failures.
Diffs
-----
src/main/python/apache/aurora/executor/BUILD 5f0ef7c12479fe2bbdebc3dacdd6ce5aa4910413
src/main/python/apache/aurora/executor/thermos_runner.py 396753e0f95ce1342dba05ea1897a6842e6547df
src/main/python/apache/aurora/executor/thermos_statuses.py PRE-CREATION
src/main/python/apache/aurora/executor/thermos_task_runner.py 7b346e253677ee9b42c57782f7f67ff63b6a0083
src/test/python/apache/aurora/executor/test_thermos_executor.py f6ca4dfd0fd262361709361c48c93799837e0a54
src/test/python/apache/aurora/executor/test_thermos_task_runner.py 8e4042b29dce8a815c5995b9e2701c95fe3f034b
Diff: https://reviews.apache.org/r/26333/diff/
Testing (updated)
-------
Added tests. Refers to Process.UnknownUserError which is added in https://reviews.apache.org/r/25972/ but not available here.
Update: ran build-support/jenkins/build.sh after the merge of 25972 and it passed.
Thanks,
Brian Wickman
Re: Review Request 26333: Add exit status contract between thermos
runner and aurora executor.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26333/
-----------------------------------------------------------
(Updated Oct. 4, 2014, 12:46 a.m.)
Review request for Aurora, Joe Smith and Kevin Sweeney.
Changes
-------
Address kevin's feedback. Integrate runner exit status into compute_status so that statuses are actually propagated to mesos task statuses.
Bugs: AURORA-175
https://issues.apache.org/jira/browse/AURORA-175
Repository: aurora
Description
-------
Adds an exit status contract between the ThermosTaskRunner and the thermos_runner.pex so that we can discriminate between losses / failures.
Diffs (updated)
-----
src/main/python/apache/aurora/executor/BUILD 5f0ef7c12479fe2bbdebc3dacdd6ce5aa4910413
src/main/python/apache/aurora/executor/thermos_runner.py 396753e0f95ce1342dba05ea1897a6842e6547df
src/main/python/apache/aurora/executor/thermos_statuses.py PRE-CREATION
src/main/python/apache/aurora/executor/thermos_task_runner.py 7b346e253677ee9b42c57782f7f67ff63b6a0083
src/test/python/apache/aurora/executor/test_thermos_executor.py f6ca4dfd0fd262361709361c48c93799837e0a54
src/test/python/apache/aurora/executor/test_thermos_task_runner.py 8e4042b29dce8a815c5995b9e2701c95fe3f034b
Diff: https://reviews.apache.org/r/26333/diff/
Testing
-------
Added tests. Refers to Process.UnknownUserError which is added in https://reviews.apache.org/r/25972/ but not available here.
Thanks,
Brian Wickman
Re: Review Request 26333: Add exit status contract between thermos
runner and aurora executor.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26333/#review55413
-----------------------------------------------------------
Hmm, I might have prematurely sent this review. I think this will still yield LOST tasks if there is no associated checkpoint stream, so it looks like there's still some contract to be mended between the ThermosTaskRunner and AuroraExecutor.
- Brian Wickman
On Oct. 3, 2014, 11:19 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26333/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 11:19 p.m.)
>
>
> Review request for Aurora, Joe Smith and Kevin Sweeney.
>
>
> Bugs: AURORA-175
> https://issues.apache.org/jira/browse/AURORA-175
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adds an exit status contract between the ThermosTaskRunner and the thermos_runner.pex so that we can discriminate between losses / failures.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/BUILD 5f0ef7c12479fe2bbdebc3dacdd6ce5aa4910413
> src/main/python/apache/aurora/executor/thermos_runner.py 396753e0f95ce1342dba05ea1897a6842e6547df
> src/main/python/apache/aurora/executor/thermos_statuses.py PRE-CREATION
> src/main/python/apache/aurora/executor/thermos_task_runner.py 7b346e253677ee9b42c57782f7f67ff63b6a0083
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py 8e4042b29dce8a815c5995b9e2701c95fe3f034b
>
> Diff: https://reviews.apache.org/r/26333/diff/
>
>
> Testing
> -------
>
> Added tests. Refers to Process.UnknownUserError which is added in https://reviews.apache.org/r/25972/ but not available here.
>
>
> Thanks,
>
> Brian Wickman
>
>