You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2024/01/11 00:39:45 UTC

[PR] Adjusts compactor error logging because of race [accumulo]

keith-turner opened a new pull request, #4151:
URL: https://github.com/apache/accumulo/pull/4151

   Noticed error logging from the compactor process and found it was caused by a race condition.  The logging indicated a compaction was not running when it was expected to, but the compaction started shortly after.  The background thread had not yet populated a set that the foreground thread was examining.  Adjusted the error logging to debug since it can happen spuriously.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Adjusts compactor error logging because of race [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner merged PR #4151:
URL: https://github.com/apache/accumulo/pull/4151


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Adjusts compactor error logging because of race [accumulo]

Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #4151:
URL: https://github.com/apache/accumulo/pull/4151#issuecomment-1887157554

   Also, this could probably target 2.1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Adjusts compactor error logging because of race [accumulo]

Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #4151:
URL: https://github.com/apache/accumulo/pull/4151#issuecomment-1887152669

   Good catch. I wonder if instead of the conditional that is currently in the Compactor (below) we should just put while loop that waits for `!running.isEmpty()`. That way the main thread will wait for the background thread to be invoked and make initial progress.
   
   ```
               List<CompactionInfo> running =
                   org.apache.accumulo.server.compaction.FileCompactor.getRunningCompactions();
               if (!running.isEmpty()) {
               ...
               } else {
                 LOG.error("Waiting on compaction thread to finish, but no RUNNING compaction");
               }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Adjusts compactor error logging because of race [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on PR #4151:
URL: https://github.com/apache/accumulo/pull/4151#issuecomment-1888146395

   Force pushed a change for 2.1 and reset the PR branch to 2.1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Adjusts compactor error logging because of race [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on PR #4151:
URL: https://github.com/apache/accumulo/pull/4151#issuecomment-1888139514

   > I wonder if instead of the conditional that is currently in the Compactor (below) we should just put while loop that waits for !running.isEmpty(). That way the main thread will wait for the background thread to be invoked and make initial progress.
   
   There are two conditions where running could be empty.  One is where the background thread has not started and the other is where it has finished.  Can not really tell which one empty means the way things currently are.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org