You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by John Sichi <js...@facebook.com> on 2010/11/09 02:55:45 UTC
Review Request: HIVE-1771: ROUND(infinity) chokes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53/
-----------------------------------------------------------
Review request for hive.
Summary
-------
Review request from jvs.
Diffs
-----
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRound.java 1032795
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/udf_round.q 1032795
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/udf_round.q.out 1032795
Diff: https://reviews.apache.org/r/53/diff
Testing
-------
Thanks,
John
Re: Review Request: HIVE-1771: ROUND(infinity) chokes
Posted by Jon Stevens <la...@gmail.com>.
> On 2010-11-09 13:50:21, Paul Yang wrote:
> > +1 Looks good. Will test/commit.
why is this still open if the issue has been closed?
- Jon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53/#review31
-----------------------------------------------------------
On 2010-11-08 18:36:25, John Sichi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53/
> -----------------------------------------------------------
>
> (Updated 2010-11-08 18:36:25)
>
>
> Review request for hive.
>
>
> Summary
> -------
>
> Review request from jvs.
>
>
> This addresses bug HIVE-1771.
> https://issues.apache.org/jira/browse/HIVE-1771
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRound.java 1032795
> http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/udf_round.q 1032795
> http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/udf_round.q.out 1032795
>
> Diff: https://reviews.apache.org/r/53/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> John
>
>
Re: Review Request: HIVE-1771: ROUND(infinity) chokes
Posted by Paul Yang <py...@facebook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53/#review31
-----------------------------------------------------------
Ship it!
+1 Looks good. Will test/commit.
- Paul
On 2010-11-08 18:36:25, John Sichi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53/
> -----------------------------------------------------------
>
> (Updated 2010-11-08 18:36:25)
>
>
> Review request for hive.
>
>
> Summary
> -------
>
> Review request from jvs.
>
>
> This addresses bug HIVE-1771.
> https://issues.apache.org/jira/browse/HIVE-1771
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRound.java 1032795
> http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/udf_round.q 1032795
> http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/udf_round.q.out 1032795
>
> Diff: https://reviews.apache.org/r/53/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> John
>
>
Re: Review Request: HIVE-1771: ROUND(infinity) chokes
Posted by John Sichi <js...@facebook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53/
-----------------------------------------------------------
(Updated 2010-11-08 18:36:25.984539)
Review request for hive.
Summary
-------
Review request from jvs.
This addresses bug HIVE-1771.
https://issues.apache.org/jira/browse/HIVE-1771
Diffs
-----
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRound.java 1032795
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/udf_round.q 1032795
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/udf_round.q.out 1032795
Diff: https://reviews.apache.org/r/53/diff
Testing
-------
Thanks,
John