You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/19 08:19:39 UTC
[GitHub] [flink] JingsongLi opened a new pull request #13684: [FLINK-19707][table-runtime] Refactor table streaming file sink
JingsongLi opened a new pull request #13684:
URL: https://github.com/apache/flink/pull/13684
## What is the purpose of the change
Refactor table streaming file sink classes for extensive compaction feature.
## Brief change log
- Extract `AbstractStreamingWriter`
- Rename Committer and Commit message.
- Make writer more generic
- Provides StreamingSink util class
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13684: [FLINK-19707][table-runtime] Refactor table streaming file sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13684:
URL: https://github.com/apache/flink/pull/13684#issuecomment-711859397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0342d3e2fb67e0160fe06ffb555ad95d0561a278",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7848",
"triggerID" : "0342d3e2fb67e0160fe06ffb555ad95d0561a278",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0342d3e2fb67e0160fe06ffb555ad95d0561a278 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7848)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13684: [FLINK-19707][table-runtime] Refactor table streaming file sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13684:
URL: https://github.com/apache/flink/pull/13684#issuecomment-711859397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0342d3e2fb67e0160fe06ffb555ad95d0561a278",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7848",
"triggerID" : "0342d3e2fb67e0160fe06ffb555ad95d0561a278",
"triggerType" : "PUSH"
}, {
"hash" : "00bb4c5d8d67c73cceb8011cf995a21306b00033",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7853",
"triggerID" : "00bb4c5d8d67c73cceb8011cf995a21306b00033",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0342d3e2fb67e0160fe06ffb555ad95d0561a278 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7848)
* 00bb4c5d8d67c73cceb8011cf995a21306b00033 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7853)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13684: [FLINK-19707][table-runtime] Refactor table streaming file sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13684:
URL: https://github.com/apache/flink/pull/13684#issuecomment-711859397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0342d3e2fb67e0160fe06ffb555ad95d0561a278",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7848",
"triggerID" : "0342d3e2fb67e0160fe06ffb555ad95d0561a278",
"triggerType" : "PUSH"
}, {
"hash" : "00bb4c5d8d67c73cceb8011cf995a21306b00033",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7853",
"triggerID" : "00bb4c5d8d67c73cceb8011cf995a21306b00033",
"triggerType" : "PUSH"
}, {
"hash" : "89cb7caace1af59acf545fb38d275020da6fe523",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7860",
"triggerID" : "89cb7caace1af59acf545fb38d275020da6fe523",
"triggerType" : "PUSH"
}, {
"hash" : "25fec6586ab590150c7e2b1b95740976b5bd01b2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7910",
"triggerID" : "25fec6586ab590150c7e2b1b95740976b5bd01b2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 89cb7caace1af59acf545fb38d275020da6fe523 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7860)
* 25fec6586ab590150c7e2b1b95740976b5bd01b2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7910)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13684: [FLINK-19707][table-runtime] Refactor table streaming file sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13684:
URL: https://github.com/apache/flink/pull/13684#issuecomment-711859397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0342d3e2fb67e0160fe06ffb555ad95d0561a278",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7848",
"triggerID" : "0342d3e2fb67e0160fe06ffb555ad95d0561a278",
"triggerType" : "PUSH"
}, {
"hash" : "00bb4c5d8d67c73cceb8011cf995a21306b00033",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7853",
"triggerID" : "00bb4c5d8d67c73cceb8011cf995a21306b00033",
"triggerType" : "PUSH"
}, {
"hash" : "89cb7caace1af59acf545fb38d275020da6fe523",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7860",
"triggerID" : "89cb7caace1af59acf545fb38d275020da6fe523",
"triggerType" : "PUSH"
}, {
"hash" : "25fec6586ab590150c7e2b1b95740976b5bd01b2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "25fec6586ab590150c7e2b1b95740976b5bd01b2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 89cb7caace1af59acf545fb38d275020da6fe523 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7860)
* 25fec6586ab590150c7e2b1b95740976b5bd01b2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #13684: [FLINK-19707][table-runtime] Refactor table streaming file sink
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #13684:
URL: https://github.com/apache/flink/pull/13684
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13684: [FLINK-19707][table-runtime] Refactor table streaming file sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13684:
URL: https://github.com/apache/flink/pull/13684#issuecomment-711859397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0342d3e2fb67e0160fe06ffb555ad95d0561a278",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7848",
"triggerID" : "0342d3e2fb67e0160fe06ffb555ad95d0561a278",
"triggerType" : "PUSH"
}, {
"hash" : "00bb4c5d8d67c73cceb8011cf995a21306b00033",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7853",
"triggerID" : "00bb4c5d8d67c73cceb8011cf995a21306b00033",
"triggerType" : "PUSH"
}, {
"hash" : "89cb7caace1af59acf545fb38d275020da6fe523",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7860",
"triggerID" : "89cb7caace1af59acf545fb38d275020da6fe523",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0342d3e2fb67e0160fe06ffb555ad95d0561a278 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7848)
* 00bb4c5d8d67c73cceb8011cf995a21306b00033 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7853)
* 89cb7caace1af59acf545fb38d275020da6fe523 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7860)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13684: [FLINK-19707][table-runtime] Refactor table streaming file sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13684:
URL: https://github.com/apache/flink/pull/13684#issuecomment-711859397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0342d3e2fb67e0160fe06ffb555ad95d0561a278",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7848",
"triggerID" : "0342d3e2fb67e0160fe06ffb555ad95d0561a278",
"triggerType" : "PUSH"
}, {
"hash" : "00bb4c5d8d67c73cceb8011cf995a21306b00033",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7853",
"triggerID" : "00bb4c5d8d67c73cceb8011cf995a21306b00033",
"triggerType" : "PUSH"
}, {
"hash" : "89cb7caace1af59acf545fb38d275020da6fe523",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7860",
"triggerID" : "89cb7caace1af59acf545fb38d275020da6fe523",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 00bb4c5d8d67c73cceb8011cf995a21306b00033 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7853)
* 89cb7caace1af59acf545fb38d275020da6fe523 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7860)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13684: [FLINK-19707][table-runtime] Refactor table streaming file sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13684:
URL: https://github.com/apache/flink/pull/13684#issuecomment-711859397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0342d3e2fb67e0160fe06ffb555ad95d0561a278",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7848",
"triggerID" : "0342d3e2fb67e0160fe06ffb555ad95d0561a278",
"triggerType" : "PUSH"
}, {
"hash" : "00bb4c5d8d67c73cceb8011cf995a21306b00033",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7853",
"triggerID" : "00bb4c5d8d67c73cceb8011cf995a21306b00033",
"triggerType" : "PUSH"
}, {
"hash" : "89cb7caace1af59acf545fb38d275020da6fe523",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7860",
"triggerID" : "89cb7caace1af59acf545fb38d275020da6fe523",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 89cb7caace1af59acf545fb38d275020da6fe523 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7860)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13684: [FLINK-19707][table-runtime] Refactor table streaming file sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13684:
URL: https://github.com/apache/flink/pull/13684#issuecomment-711859397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0342d3e2fb67e0160fe06ffb555ad95d0561a278",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7848",
"triggerID" : "0342d3e2fb67e0160fe06ffb555ad95d0561a278",
"triggerType" : "PUSH"
}, {
"hash" : "00bb4c5d8d67c73cceb8011cf995a21306b00033",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "00bb4c5d8d67c73cceb8011cf995a21306b00033",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0342d3e2fb67e0160fe06ffb555ad95d0561a278 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7848)
* 00bb4c5d8d67c73cceb8011cf995a21306b00033 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lirui-apache commented on a change in pull request #13684: [FLINK-19707][table-runtime] Refactor table streaming file sink
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #13684:
URL: https://github.com/apache/flink/pull/13684#discussion_r508190468
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/stream/StreamingSink.java
##########
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.filesystem.stream;
+
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.common.typeinfo.Types;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.datastream.DataStreamSink;
+import org.apache.flink.streaming.api.functions.sink.DiscardingSink;
+import org.apache.flink.streaming.api.functions.sink.filesystem.StreamingFileSink;
+import org.apache.flink.table.catalog.ObjectIdentifier;
+import org.apache.flink.table.filesystem.FileSystemFactory;
+import org.apache.flink.table.filesystem.TableMetaStoreFactory;
+
+import java.util.List;
+
+import static org.apache.flink.table.filesystem.FileSystemOptions.SINK_PARTITION_COMMIT_POLICY_KIND;
+
+/**
+ * Helper for creating streaming file sink.
+ */
+public class StreamingSink {
+ private StreamingSink() {
+ }
+
+ public static <T> DataStream<PartitionCommitInfo> writer(
Review comment:
Add some comments to explain what these method do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13684: [FLINK-19707][table-runtime] Refactor table streaming file sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13684:
URL: https://github.com/apache/flink/pull/13684#issuecomment-711859397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0342d3e2fb67e0160fe06ffb555ad95d0561a278",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7848",
"triggerID" : "0342d3e2fb67e0160fe06ffb555ad95d0561a278",
"triggerType" : "PUSH"
}, {
"hash" : "00bb4c5d8d67c73cceb8011cf995a21306b00033",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7853",
"triggerID" : "00bb4c5d8d67c73cceb8011cf995a21306b00033",
"triggerType" : "PUSH"
}, {
"hash" : "89cb7caace1af59acf545fb38d275020da6fe523",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "89cb7caace1af59acf545fb38d275020da6fe523",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0342d3e2fb67e0160fe06ffb555ad95d0561a278 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7848)
* 00bb4c5d8d67c73cceb8011cf995a21306b00033 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7853)
* 89cb7caace1af59acf545fb38d275020da6fe523 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13684: [FLINK-19707][table-runtime] Refactor table streaming file sink
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13684:
URL: https://github.com/apache/flink/pull/13684#issuecomment-711828900
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 0342d3e2fb67e0160fe06ffb555ad95d0561a278 (Mon Oct 19 08:22:53 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13684: [FLINK-19707][table-runtime] Refactor table streaming file sink
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13684:
URL: https://github.com/apache/flink/pull/13684#issuecomment-711859397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0342d3e2fb67e0160fe06ffb555ad95d0561a278",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0342d3e2fb67e0160fe06ffb555ad95d0561a278",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0342d3e2fb67e0160fe06ffb555ad95d0561a278 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org