You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by admackin <gi...@git.apache.org> on 2015/10/08 08:38:08 UTC

[GitHub] spark pull request: Akka framesize units should be specified

GitHub user admackin opened a pull request:

    https://github.com/apache/spark/pull/9025

    Akka framesize units should be specified

    1.4 docs noted that the units were MB - i have assumed this is still the case

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/admackin/spark master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/9025.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9025
    
----
commit d5d88e2eb64303e5983c0dd22da23af525f68344
Author: admackin <ad...@users.noreply.github.com>
Date:   2015-10-08T06:35:47Z

    Note units for akka framesize
    
    To stop anyone else wasting 15 minutes of their life Googling for this like I did. 1.4 docs specified the units, and they should continue to be there I think.

commit 2fff84b4887c49d37dfe24bbc11a349b9e9a307c
Author: admackin <ad...@users.noreply.github.com>
Date:   2015-10-08T06:36:30Z

    Merge pull request #1 from admackin/conf-akka-framesize-units
    
    Note units for akka framesize

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: Akka framesize units should be specified

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/9025


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: Akka framesize units should be specified

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:

    https://github.com/apache/spark/pull/9025#issuecomment-146438888
  
    Thanks - I've merged this.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: Akka framesize units should be specified

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9025#issuecomment-146434046
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org