[GitHub] [geode] DonalEvans commented on pull request #7227: feature/GEODE-9832: SMOVE Command Support

[GitBox <gi...@apache.org>]

DonalEvans commented on pull request #7227:
URL: https://github.com/apache/geode/pull/7227#issuecomment-1006175157


   It looks like there's a failing tcl test due to incorrect behaviour when the destination key exists but is not a Set and the member being moved is not present in the source set. The following test passes when run against native Redis but fails when run against geode-for-redis:
   ```
     @Test
     public void smove_withNonSetDestinationKey_returnsWrongtypeError() {
       jedis.sadd(sourceKey, sourceMembers);
       jedis.set(destKey, "aString");
   
       assertThatThrownBy(() -> jedis.smove(sourceKey, destKey, "nonPresentMember"))
           .hasMessageContaining("WRONGTYPE");
     }
   ```
   
   The solution to this is to move this line:
   ```
   RedisSet destination = regionProvider.getTypedRedisData(REDIS_SET, destKey, false);
   ```
   to be immediately below this one:
   ```
   RedisSet source = regionProvider.getTypedRedisData(REDIS_SET, sourceKey, false);
   ``` 
   in `RedisSet.smove()`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org