You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramachandran Krishnan <ra...@gmail.com> on 2023/02/05 02:53:47 UTC
Re: Review Request 74285: RANGER-4057 :[Ranger] /tags/tags/cache/reset api give 200 response for invalid service
> On Jan. 24, 2023, 5:13 p.m., Madhan Neethiraj wrote:
> > Ship It!
Madhan Neethiraj -- I feel this fix will be good go to the master
- Ramachandran
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74285/#review225124
-----------------------------------------------------------
On Jan. 24, 2023, 5:46 a.m., Ramachandran Krishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74285/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2023, 5:46 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Kirby Zhou, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-4057
> https://issues.apache.org/jira/browse/RANGER-4057
>
>
> Repository: ranger
>
>
> Description
> -------
>
> [Ranger] /tags/tags/cache/reset api give 200 response for invalid service
>
> Curl Request :
>
> curl -s -L -X GET "https://***********/service/tags/tags/cache/reset?abba" -H "Authorization: Basic *************=="
> Response :
> 200 Status with false
>
> Same for response for any service which we pass .
>
> Expected : If service is existing , response should be 200 with proper message ,
> Else service is non -existing response should be 400 with error message
>
>
> The same issue is present for the
>
> [Ranger]:/plugins/policies/cache/reset API give 200 response for invalid service
>
> Curl Request :
>
> curl -s -L -X GET "https://***********plugins/policies/cache/reset?serviceName=aaa" -H "Authorization: Basic *************=="
> Response :
> 200 Status with false
>
> Same for the response for any service which we pass.
>
> Expected: If service is existing, the response should be 200 with a proper message,
> Else service is non -existing response should be 400 with an error message
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java ec02f47f7
> security-admin/src/main/java/org/apache/ranger/rest/TagREST.java 443188f9a
> security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java 8fdcc43c8
> security-admin/src/test/java/org/apache/ranger/rest/TestTagREST.java 5986d5182
>
>
> Diff: https://reviews.apache.org/r/74285/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ramachandran Krishnan
>
>