You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/22 02:08:44 UTC

[GitHub] HyukjinKwon edited a comment on issue #23863: [SPARK-26960][ML] Wait for listener bus to clear in MLEventsSuite to reduce test flakiness

HyukjinKwon edited a comment on issue #23863: [SPARK-26960][ML] Wait for listener bus to clear in MLEventsSuite to reduce test flakiness
URL: https://github.com/apache/spark/pull/23863#issuecomment-466244688
 
 
   Merged to master.
   
   @jkbradley, BTW, I have no objection with reverting this feature if you see any tricky issue by this later in the future - for this possibility, I made this codes as isolated as possible, and I marked this as unstable with a strong warning:
   
   https://github.com/apache/spark/blob/dfb880951a8de55c587c1bf8b696df50eae6e68a/mllib/src/main/scala/org/apache/spark/ml/events.scala#L34-L35
   
   so that it warns it might be reverted even after the release.
   
   Sorry I merged this without your input. I was working on Apache Atlas <> Apache Spark ML integration so maybe I rushed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org