You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Prasad Chakka (JIRA)" <ji...@apache.org> on 2008/09/15 20:25:44 UTC
[jira] Created: (HADOOP-4175) Incorporate metastore server review
comments
Incorporate metastore server review comments
--------------------------------------------
Key: HADOOP-4175
URL: https://issues.apache.org/jira/browse/HADOOP-4175
Project: Hadoop Core
Issue Type: Bug
Components: contrib/hive
Affects Versions: 0.19.0
Reporter: Prasad Chakka
Assignee: Prasad Chakka
As the title says. Will list detailed fixes in the comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4175) Incorporate metastore server review
comments
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631097#action_12631097 ]
Prasad Chakka commented on HADOOP-4175:
---------------------------------------
9) Add unit tests for stand-alone & thrad-safe metastore server
> Incorporate metastore server review comments
> --------------------------------------------
>
> Key: HADOOP-4175
> URL: https://issues.apache.org/jira/browse/HADOOP-4175
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
>
> As the title says. Will list detailed fixes in the comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4175) Incorporate metastore server review
comments
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Chakka updated HADOOP-4175:
----------------------------------
Attachment: hadoop-4175-2.patch
after resolving conflicts.
> Incorporate metastore server review comments
> --------------------------------------------
>
> Key: HADOOP-4175
> URL: https://issues.apache.org/jira/browse/HADOOP-4175
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Fix For: 0.19.0
>
> Attachments: hadoop-4175-1.patch, hadoop-4175-2.patch
>
>
> As the title says. Will list detailed fixes in the comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4175) Incorporate metastore server review
comments
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Chakka updated HADOOP-4175:
----------------------------------
Attachment: hadoop-4175-1.patch
> Incorporate metastore server review comments
> --------------------------------------------
>
> Key: HADOOP-4175
> URL: https://issues.apache.org/jira/browse/HADOOP-4175
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Attachments: hadoop-4175-1.patch
>
>
> As the title says. Will list detailed fixes in the comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4175) Incorporate metastore server review
comments
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Chakka updated HADOOP-4175:
----------------------------------
Status: Open (was: Patch Available)
need to update some files
> Incorporate metastore server review comments
> --------------------------------------------
>
> Key: HADOOP-4175
> URL: https://issues.apache.org/jira/browse/HADOOP-4175
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Fix For: 0.19.0
>
> Attachments: hadoop-4175-1.patch
>
>
> As the title says. Will list detailed fixes in the comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4175) Incorporate metastore server review
comments
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632521#action_12632521 ]
Hadoop QA commented on HADOOP-4175:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12390401/hadoop-4175-2.patch
against trunk revision 696846.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 12 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3314/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3314/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3314/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3314/console
This message is automatically generated.
> Incorporate metastore server review comments
> --------------------------------------------
>
> Key: HADOOP-4175
> URL: https://issues.apache.org/jira/browse/HADOOP-4175
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Fix For: 0.19.0
>
> Attachments: hadoop-4175-1.patch, hadoop-4175-2.patch
>
>
> As the title says. Will list detailed fixes in the comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4175) Incorporate metastore server review
comments
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Chakka updated HADOOP-4175:
----------------------------------
Status: Patch Available (was: Open)
> Incorporate metastore server review comments
> --------------------------------------------
>
> Key: HADOOP-4175
> URL: https://issues.apache.org/jira/browse/HADOOP-4175
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Fix For: 0.19.0
>
> Attachments: hadoop-4175-1.patch, hadoop-4175-2.patch
>
>
> As the title says. Will list detailed fixes in the comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4175) Incorporate metastore server review
comments
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632658#action_12632658 ]
dhruba borthakur commented on HADOOP-4175:
------------------------------------------
The test failures are not related to this patch. The failed tests are all in the mapred/scheuduler area. I see the same tests failing for other patch submissions. Unless somebody thinks otherwise, I will commit this patch later today.
> Incorporate metastore server review comments
> --------------------------------------------
>
> Key: HADOOP-4175
> URL: https://issues.apache.org/jira/browse/HADOOP-4175
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Fix For: 0.19.0
>
> Attachments: hadoop-4175-1.patch, hadoop-4175-2.patch
>
>
> As the title says. Will list detailed fixes in the comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4175) Incorporate metastore server review
comments
Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631151#action_12631151 ]
Ashish Thusoo commented on HADOOP-4175:
---------------------------------------
We are referring to lists as arrays for all user facing statements...
Inline Comments:
ql/src/test/results/clientpositive/input3.q.out:2: We should stick to array. The last feedback that we got from the analysts was that array is more intuitive than lists.
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java:276: list to arrays
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java:332: Call this default instead of d?
> Incorporate metastore server review comments
> --------------------------------------------
>
> Key: HADOOP-4175
> URL: https://issues.apache.org/jira/browse/HADOOP-4175
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
>
> As the title says. Will list detailed fixes in the comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4175) Incorporate metastore server review
comments
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631096#action_12631096 ]
Prasad Chakka commented on HADOOP-4175:
---------------------------------------
1) Move Type name constants into SerDe thrift ddl file
2) Cleanup SerdeInfo object to have only serializationLib (ie name of the class to be loaded) & name as specific fields. Move other properties into generic key/val hash map
3) Add numbered ids to thrift structures
4) change the name of the locationURI field of Database object to description
5) Specify that only range partitioning is allowed
6) Use isTableExists instead of exception catching
7) Read jpox config variables from hive-default.xml instead of jpox.properties
8) Change Partition.getPath() return a single path instead of list of paths.
> Incorporate metastore server review comments
> --------------------------------------------
>
> Key: HADOOP-4175
> URL: https://issues.apache.org/jira/browse/HADOOP-4175
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
>
> As the title says. Will list detailed fixes in the comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4175) Incorporate metastore server review
comments
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632780#action_12632780 ]
Zheng Shao commented on HADOOP-4175:
------------------------------------
Please do NOT commit this patch. This patch is included in http://issues.apache.org/jira/browse/HADOOP-4205.
> Incorporate metastore server review comments
> --------------------------------------------
>
> Key: HADOOP-4175
> URL: https://issues.apache.org/jira/browse/HADOOP-4175
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Fix For: 0.19.0
>
> Attachments: hadoop-4175-1.patch, hadoop-4175-2.patch
>
>
> As the title says. Will list detailed fixes in the comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4175) Incorporate metastore server review
comments
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Chakka updated HADOOP-4175:
----------------------------------
Fix Version/s: 0.19.0
Hadoop Flags: [Reviewed]
Status: Patch Available (was: Open)
> Incorporate metastore server review comments
> --------------------------------------------
>
> Key: HADOOP-4175
> URL: https://issues.apache.org/jira/browse/HADOOP-4175
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Fix For: 0.19.0
>
> Attachments: hadoop-4175-1.patch
>
>
> As the title says. Will list detailed fixes in the comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4175) Incorporate metastore server review
comments
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HADOOP-4175:
-------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
The patch is included and committed with http://issues.apache.org/jira/browse/HADOOP-4205
> Incorporate metastore server review comments
> --------------------------------------------
>
> Key: HADOOP-4175
> URL: https://issues.apache.org/jira/browse/HADOOP-4175
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Fix For: 0.19.0
>
> Attachments: hadoop-4175-1.patch, hadoop-4175-2.patch
>
>
> As the title says. Will list detailed fixes in the comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4175) Incorporate metastore server review
comments
Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632035#action_12632035 ]
Ashish Thusoo commented on HADOOP-4175:
---------------------------------------
+1
looks good.
> Incorporate metastore server review comments
> --------------------------------------------
>
> Key: HADOOP-4175
> URL: https://issues.apache.org/jira/browse/HADOOP-4175
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Attachments: hadoop-4175-1.patch
>
>
> As the title says. Will list detailed fixes in the comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4175) Incorporate metastore server review
comments
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631099#action_12631099 ]
Pete Wyckoff commented on HADOOP-4175:
--------------------------------------
can you update the description with the tasks since that gets sent along with emails?
> Incorporate metastore server review comments
> --------------------------------------------
>
> Key: HADOOP-4175
> URL: https://issues.apache.org/jira/browse/HADOOP-4175
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/hive
> Affects Versions: 0.19.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
>
> As the title says. Will list detailed fixes in the comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.