You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "zhoujinsong (via GitHub)" <gi...@apache.org> on 2024/05/16 03:33:21 UTC
[PR] [AMORO-1744] Rename name with arctic identifier in amoro-mixed-format-trino module [amoro]
zhoujinsong opened a new pull request, #2838:
URL: https://github.com/apache/amoro/pull/2838
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://amoro.apache.org/how-to-contribute/
2. If the PR is related to an issue in https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title, e.g., '[AMORO-XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][AMORO-XXXX] Your PR title ...'.
-->
## Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about its use case.
2. If you fix a bug, you can clarify why it is a bug.
3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related issue
-->
As titiled
## Brief change log
<!--
Clearly describe the changes made in modules, classes, methods, etc.
-->
- Change the name of classes with the arctic identifier.
- Change the name of variables and methods with the arctic identifier.
- Change the comments with the arctic identifier.
- Change related documentation.
## How was this patch tested?
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] Run test locally before making a pull request
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-1744] Rename name with arctic identifier in amoro-mixed-format-trino module [amoro]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2838:
URL: https://github.com/apache/amoro/pull/2838#issuecomment-2113965984
## [Codecov](https://app.codecov.io/gh/apache/amoro/pull/2838?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `74.80315%` with `32 lines` in your changes are missing coverage. Please review.
> Project coverage is 35.95%. Comparing base [(`a9a624f`)](https://app.codecov.io/gh/apache/amoro/commit/a9a624f53d2349b0e49e0e0005937336ae022d07?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`9804243`)](https://app.codecov.io/gh/apache/amoro/pull/2838?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 6 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/amoro/pull/2838?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ro/trino/MixedFormatCatalogSupportTableSuffix.java](https://app.codecov.io/gh/apache/amoro/pull/2838?src=pr&el=tree&filepath=amoro-mixed-format%2Famoro-mixed-format-trino%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Famoro%2Ftrino%2FMixedFormatCatalogSupportTableSuffix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1vcm8tbWl4ZWQtZm9ybWF0L2Ftb3JvLW1peGVkLWZvcm1hdC10cmluby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvYW1vcm8vdHJpbm8vTWl4ZWRGb3JtYXRDYXRhbG9nU3VwcG9ydFRhYmxlU3VmZml4LmphdmE=) | 33.33% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/amoro/pull/2838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/amoro/trino/keyed/KeyedConnectorMetadata.java](https://app.codecov.io/gh/apache/amoro/pull/2838?src=pr&el=tree&filepath=amoro-mixed-format%2Famoro-mixed-format-trino%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Famoro%2Ftrino%2Fkeyed%2FKeyedConnectorMetadata.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1vcm8tbWl4ZWQtZm9ybWF0L2Ftb3JvLW1peGVkLWZvcm1hdC10cmluby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvYW1vcm8vdHJpbm8va2V5ZWQvS2V5ZWRDb25uZWN0b3JNZXRhZGF0YS5qYXZh) | 70.00% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/amoro/pull/2838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/amoro/trino/MixedFormatTrinoCatalog.java](https://app.codecov.io/gh/apache/amoro/pull/2838?src=pr&el=tree&filepath=amoro-mixed-format%2Famoro-mixed-format-trino%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Famoro%2Ftrino%2FMixedFormatTrinoCatalog.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1vcm8tbWl4ZWQtZm9ybWF0L2Ftb3JvLW1peGVkLWZvcm1hdC10cmluby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvYW1vcm8vdHJpbm8vTWl4ZWRGb3JtYXRUcmlub0NhdGFsb2cuamF2YQ==) | 44.44% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/amoro/pull/2838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/amoro/trino/AmoroErrorCode.java](https://app.codecov.io/gh/apache/amoro/pull/2838?src=pr&el=tree&filepath=amoro-mixed-format%2Famoro-mixed-format-trino%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Famoro%2Ftrino%2FAmoroErrorCode.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1vcm8tbWl4ZWQtZm9ybWF0L2Ftb3JvLW1peGVkLWZvcm1hdC10cmluby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvYW1vcm8vdHJpbm8vQW1vcm9FcnJvckNvZGUuamF2YQ==) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/amoro/pull/2838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/amoro/trino/MixedFormatConnectorMetadata.java](https://app.codecov.io/gh/apache/amoro/pull/2838?src=pr&el=tree&filepath=amoro-mixed-format%2Famoro-mixed-format-trino%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Famoro%2Ftrino%2FMixedFormatConnectorMetadata.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1vcm8tbWl4ZWQtZm9ybWF0L2Ftb3JvLW1peGVkLWZvcm1hdC10cmluby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvYW1vcm8vdHJpbm8vTWl4ZWRGb3JtYXRDb25uZWN0b3JNZXRhZGF0YS5qYXZh) | 62.50% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/amoro/pull/2838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/amoro/trino/keyed/KeyedConnectorPageSource.java](https://app.codecov.io/gh/apache/amoro/pull/2838?src=pr&el=tree&filepath=amoro-mixed-format%2Famoro-mixed-format-trino%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Famoro%2Ftrino%2Fkeyed%2FKeyedConnectorPageSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1vcm8tbWl4ZWQtZm9ybWF0L2Ftb3JvLW1peGVkLWZvcm1hdC10cmluby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvYW1vcm8vdHJpbm8va2V5ZWQvS2V5ZWRDb25uZWN0b3JQYWdlU291cmNlLmphdmE=) | 66.66% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/amoro/pull/2838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../amoro/trino/keyed/KeyedConnectorSplitManager.java](https://app.codecov.io/gh/apache/amoro/pull/2838?src=pr&el=tree&filepath=amoro-mixed-format%2Famoro-mixed-format-trino%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Famoro%2Ftrino%2Fkeyed%2FKeyedConnectorSplitManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1vcm8tbWl4ZWQtZm9ybWF0L2Ftb3JvLW1peGVkLWZvcm1hdC10cmluby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvYW1vcm8vdHJpbm8va2V5ZWQvS2V5ZWRDb25uZWN0b3JTcGxpdE1hbmFnZXIuamF2YQ==) | 77.77% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/amoro/pull/2838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../amoro/trino/DefaultMixedFormatCatalogFactory.java](https://app.codecov.io/gh/apache/amoro/pull/2838?src=pr&el=tree&filepath=amoro-mixed-format%2Famoro-mixed-format-trino%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Famoro%2Ftrino%2FDefaultMixedFormatCatalogFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1vcm8tbWl4ZWQtZm9ybWF0L2Ftb3JvLW1peGVkLWZvcm1hdC10cmluby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvYW1vcm8vdHJpbm8vRGVmYXVsdE1peGVkRm9ybWF0Q2F0YWxvZ0ZhY3RvcnkuamF2YQ==) | 87.50% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/amoro/pull/2838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #2838 +/- ##
============================================
- Coverage 35.96% 35.95% -0.01%
+ Complexity 386 383 -3
============================================
Files 46 45 -1
Lines 4708 4700 -8
Branches 513 513
============================================
- Hits 1693 1690 -3
+ Misses 2847 2842 -5
Partials 168 168
```
| [Flag](https://app.codecov.io/gh/apache/amoro/pull/2838/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [trino](https://app.codecov.io/gh/apache/amoro/pull/2838/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `35.95% <74.80%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/amoro/pull/2838?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-1744] Rename name with arctic identifier in amoro-mixed-format-trino module [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong merged PR #2838:
URL: https://github.com/apache/amoro/pull/2838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-1744] Rename name with arctic identifier in amoro-mixed-format-trino module [amoro]
Posted by "HuangFru (via GitHub)" <gi...@apache.org>.
HuangFru commented on code in PR #2838:
URL: https://github.com/apache/amoro/pull/2838#discussion_r1603046486
##########
amoro-mixed-format/amoro-mixed-format-trino/src/main/java/org/apache/amoro/trino/MixedFormatConnectorFactory.java:
##########
@@ -56,22 +56,17 @@
import io.trino.spi.connector.TableProcedureMetadata;
import io.trino.spi.procedure.Procedure;
import io.trino.spi.type.TypeManager;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
import org.weakref.jmx.guice.MBeanModule;
import java.util.Map;
import java.util.Optional;
import java.util.Set;
/** Factory to generate {@link Connector} */
-public class ArcticConnectorFactory implements ConnectorFactory {
-
- private static final Logger LOG = LoggerFactory.getLogger(ArcticConnectorFactory.class);
-
+public class MixedFormatConnectorFactory implements ConnectorFactory {
Review Comment:
Same as above comment.
##########
amoro-mixed-format/amoro-mixed-format-trino/src/main/java/org/apache/amoro/trino/MixedFormatConfig.java:
##########
@@ -21,8 +21,8 @@
import io.airlift.configuration.Config;
import io.airlift.configuration.ConfigDescription;
-/** Arctic config */
-public class ArcticConfig {
+/** Mixed-format configurations */
+public class MixedFormatConfig {
Review Comment:
Maybe `AmoroConfig`? The same applies to the following configuration. I feel amoro.xxx would be better, because it actually represents the connector name. Users set these configurations according to connector.xxx, such as iceberg.xxx. Or, does this mean our connector name is mix-forma, if so, please ignore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-1744] Rename name with arctic identifier in amoro-mixed-format-trino module [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on code in PR #2838:
URL: https://github.com/apache/amoro/pull/2838#discussion_r1604261005
##########
amoro-mixed-format/amoro-mixed-format-trino/src/main/java/org/apache/amoro/trino/MixedFormatConfig.java:
##########
@@ -21,8 +21,8 @@
import io.airlift.configuration.Config;
import io.airlift.configuration.ConfigDescription;
-/** Arctic config */
-public class ArcticConfig {
+/** Mixed-format configurations */
+public class MixedFormatConfig {
Review Comment:
Yes,the new connector name is mixed-format, and it is used for mixed-format only now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-1744] Rename name with arctic identifier in amoro-mixed-format-trino module [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on PR #2838:
URL: https://github.com/apache/amoro/pull/2838#issuecomment-2116540237
Thanks for the review, @HuangFru
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org