You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (Commented) (JIRA)" <ji...@apache.org> on 2011/10/03 12:30:33 UTC
[jira] [Commented] (WICKET-4074) RequestLogger needs a clear
separation of concerns
[ https://issues.apache.org/jira/browse/WICKET-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119232#comment-13119232 ]
Martin Grigorov commented on WICKET-4074:
-----------------------------------------
The patch assumes that the log data should be constructed in IRequestHandler#detach(), i.e. it will be available if the RequestLogger is used at the end of RequestCycle#detach(). If this assumption is OK then fine.
Recently we found that RequestLogger impls should use two SLF4J loggers - one for tracing, debug, ..., errors and another for the dump of the collected data. This way the user application can configure it to write to a different file and this way parsing will be easier because the log file will contain just the parseable data.
As I said in my earlier comment I'll let another dev to review it. Igor also suggested once such solution, now is the time to share his opinion how good/bad is this patch.
> RequestLogger needs a clear separation of concerns
> --------------------------------------------------
>
> Key: WICKET-4074
> URL: https://issues.apache.org/jira/browse/WICKET-4074
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5.1
> Reporter: Emond Papegaaij
> Attachments: 0001-improved-request-logger.patch, 0002-remove-generic-type-from-ILoggableRequestHandler.patch, 0003-move-LogData-to-handler.logger.patch, 0004-make-logdata-members-final.patch, 0005-json-request-logger-using-jackson.patch, ALL-new-request-logger.patch
>
>
> As a follow-up on WICKET-3919 and WICKET-4029, I've been working on a patch for the RequestLogger. This patch makes RequestHandles responsible for providing data to log. The RequestLogger collects this data and logs it. RequestHandles that are to be logged, must implement ILoggableRequestHandle.
> In short, this patch changes the following things:
> ILoggableRequestHandle added and all major RequestHandles changed to implement this interface
> IStatedRequestLogger added and AbstractRequestLogger changed to implement this interface (separate logging step after the detach phase)
> Various implementations of ILogData added (data logged by request handlers)
> RequestLogger simplified to use ILoggableRequestHandle
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira