You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2021/01/21 11:27:50 UTC

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #832: PARQUET-1926: Add LogicalType support to ThriftType

gszadovszky commented on a change in pull request #832:
URL: https://github.com/apache/parquet-mr/pull/832#discussion_r561796333



##########
File path: parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftSchemaConvertVisitor.java
##########
@@ -325,7 +323,7 @@ private ConvertedField visitPrimitiveType(PrimitiveTypeName type, LogicalTypeAnn
 
   @Override
   public ConvertedField visit(EnumType enumType, State state) {
-    return visitPrimitiveType(BINARY, enumType(), state);
+    return visitPrimitiveType(BINARY, LogicalTypeAnnotation.enumType(), state);

Review comment:
       Why you don't like static imports? This change (and the removing of the related import) seems to be useless.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org