You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by "sjgllgh (via GitHub)" <gi...@apache.org> on 2023/09/25 07:15:52 UTC
[GitHub] [linkis] sjgllgh opened a new pull request, #4915: [BUG] Fix em sort error
sjgllgh opened a new pull request, #4915:
URL: https://github.com/apache/linkis/pull/4915
### What is the purpose of the change
Fix the bug that the sortByResource method in ResourceNodeSelectRule violates the general contract of comparators.
### Related issues/PRs
Related issues: #4911
### Brief change log
- Added and implemented a compare method for the Resource abstract class and its subclasses.;
- Modified the Java class ResourceNodeSelectRule to ensure that sortByResource uses the correct sorting method.
### Note
- For LoadInstanceResource, memory is compared first. If the memory is the same, the number of CPU cores is compared. When the number of CPU cores is the same, the number of instances that have been launched will be compared. Other subcategories also adopted similar comparison rules.
### Checklist
- [x] I have read the [Contributing Guidelines on pull requests](https://github.com/facebook/docusaurus/blob/main/CONTRIBUTING.md#pull-requests).
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [x] I have added tests corresponding to this change
- [x] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the [Linkis mailing list](https://linkis.apache.org/community/how-to-subscribe) first)
- [x] **If this is a code change**: I have written unit tests to fully verify the new behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [linkis] peacewong merged pull request #4915: [BUG] Fix em sort error
Posted by "peacewong (via GitHub)" <gi...@apache.org>.
peacewong merged PR #4915:
URL: https://github.com/apache/linkis/pull/4915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org