You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/01/07 13:29:48 UTC

[GitHub] chetanmeh opened a new issue #4203: Reduce overhead in metric update flow

chetanmeh opened a new issue #4203: Reduce overhead in metric update flow
URL: https://github.com/apache/incubator-openwhisk/issues/4203
 
 
   Currently for each Metric update `MetricEmitter` resolves the metric instance everytime. [Kamon docs][1] suggest
   
   > When possible, define and refine your metrics up front, as a static member or instance members on the instrumented components of your services. **This saves a bit of time in looking up instruments.**
   
   As metric updates happen in critical path we should try to reduce this overhead. One way would be to store the metric reference in `LogMarkerToken` itself as all metric instance are function of that and `LogMarkerToken` are explicitly reference thus avoid any lookup overhead.
   
   See also discussion [here][2]
   
   [1]: https://kamon.io/documentation/1.x/core/basics/metrics/
   [2]: https://github.com/apache/incubator-openwhisk/pull/4165#discussion_r245491258

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services