You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/01/06 12:22:39 UTC
[jira] [Commented] (THRIFT-3526) Code generated by py:utf8strings
does not work for Python3
[ https://issues.apache.org/jira/browse/THRIFT-3526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15085421#comment-15085421 ]
ASF GitHub Bot commented on THRIFT-3526:
----------------------------------------
GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/776
THRIFT-3526 Code generated by py:utf8strings does not work for Python3
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuke/thrift THRIFT-3526
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/776.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #776
----
commit b34ff7319373b87e10060d5cc35222d4933310c2
Author: Nobuaki Sukegawa <ns...@apache.org>
Date: 2016-01-06T05:52:50Z
THRIFT-3525 py:dynamic fails to handle binary list/set/map element
commit 64929e532becd7e0f52b5af2630020663b74fd57
Author: Nobuaki Sukegawa <ns...@apache.org>
Date: 2016-01-06T05:45:19Z
THRIFT-3526 Code generated by py:utf8strings does not work for Python3
----
> Code generated by py:utf8strings does not work for Python3
> ----------------------------------------------------------
>
> Key: THRIFT-3526
> URL: https://issues.apache.org/jira/browse/THRIFT-3526
> Project: Thrift
> Issue Type: Bug
> Reporter: Aki Sukegawa
> Assignee: Aki Sukegawa
>
> We are adding decode/encode('utf-8') unconditionally, so the code is incompatible with Python 3.
> The patch fixes this by generating simple if/else.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)