You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "mariiaKraievska (via GitHub)" <gi...@apache.org> on 2025/05/23 10:32:03 UTC
[PR] FINERACT-2276: Deprecate findExistingTransactionIds and fetch only the ids from database instead [fineract]
mariiaKraievska opened a new pull request, #4688:
URL: https://github.com/apache/fineract/pull/4688
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2276: Deprecate findExistingTransactionIds and fetch only the ids from database instead [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #4688:
URL: https://github.com/apache/fineract/pull/4688#issuecomment-2906886645
> I mean I understand the intent here and it's good but this could have side-effects to the behavior of the business logic.
>
> The former approach (what you removed) is using Hibernate's 1st level cache to retrieve the loan transactions for a loan. That means whenever a loan is loaded with the corresponding transactions, it'll only see those transactions even if something during the time of execution changes in the database.
>
> Another thing with the change is the fact that now whenever we need the transaction list for a loan, it'll go to the database every time resulting in performance degradation.
>
> Thoughts @mariiaKraievska @adamsaghy ?
>
> UPDATE: probably the first issue doesn't exist currently in Fineract because I see the tests are green.
we are talking about loan ids here. I see performance issue by the fact every transactions of the loan is always fertched and some other entities as well alongside with the transactions. these methods sole and only purpose was to support Fineract weird journal entry creation logic!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2276: Deprecate findExistingTransactionIds and fetch only the ids from database instead [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #4688:
URL: https://github.com/apache/fineract/pull/4688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org