You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gastón Kleiman <ga...@mesosphere.com> on 2017/01/18 19:01:10 UTC
Review Request 55676: Moved `getRootContainerId` to `protobuf_utils`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55676/
-----------------------------------------------------------
Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, Alexander Rojas, haosdent huang, and Vinod Kone.
Bugs: MESOS-6864
https://issues.apache.org/jira/browse/MESOS-6864
Repository: mesos
Description
-------
This method is pretty generic and should not be a part of the Mesos
containerizer code.
Diffs
-----
CHANGELOG a8d080555a3948c796116af90c17dd71e1dea5d2
src/common/protobuf_utils.hpp bca9ace6cb37047bb08466c4fb14028bbb818446
src/common/protobuf_utils.cpp af3c2a660f91c366ca5ffe8671d10c4a270bbbcc
src/slave/containerizer/composing.cpp 4fb7ba5cadd36be00be61aa00a69c38c44649aee
src/slave/containerizer/mesos/containerizer.cpp 8bf8a7774a38131c53f6d91c7f09f5dedd9d4cb4
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp b3a269535517222a1d85d8be1fdf5b865d6a3fc6
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp e1cac954848e618a03ddb82fd6d040ae1d948e82
src/slave/containerizer/mesos/utils.hpp a54106dc4893bb222f42ede936ac9029e817faf9
src/slave/containerizer/mesos/utils.cpp 4e2a01495909c07f320af416ff4dc59f7328c710
src/slave/slave.cpp 205138add7a63289ff8ed81138f8b603828c748e
src/tests/slave_recovery_tests.cpp 9cf1d461cf5c6ac1f51ac963360a17e37f558505
Diff: https://reviews.apache.org/r/55676/diff/
Testing
-------
`make check` in macOS and Linux.
Thanks,
Gast�n Kleiman
Re: Review Request 55676: Moved `getRootContainerId` to
`protobuf_utils`.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55676/#review162267
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On Jan. 19, 2017, 11:15 a.m., Gast�n Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55676/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2017, 11:15 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, Alexander Rojas, haosdent huang, and Vinod Kone.
>
>
> Bugs: MESOS-6864
> https://issues.apache.org/jira/browse/MESOS-6864
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This method is pretty generic and should not be a part of the Mesos
> containerizer code.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp bca9ace6cb37047bb08466c4fb14028bbb818446
> src/common/protobuf_utils.cpp af3c2a660f91c366ca5ffe8671d10c4a270bbbcc
> src/slave/containerizer/composing.cpp 4fb7ba5cadd36be00be61aa00a69c38c44649aee
> src/slave/containerizer/mesos/containerizer.cpp 8bf8a7774a38131c53f6d91c7f09f5dedd9d4cb4
> src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp b3a269535517222a1d85d8be1fdf5b865d6a3fc6
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp e1cac954848e618a03ddb82fd6d040ae1d948e82
> src/slave/containerizer/mesos/utils.hpp a54106dc4893bb222f42ede936ac9029e817faf9
> src/slave/containerizer/mesos/utils.cpp 4e2a01495909c07f320af416ff4dc59f7328c710
>
> Diff: https://reviews.apache.org/r/55676/diff/
>
>
> Testing
> -------
>
> `make check` in macOS and Linux.
>
>
> Thanks,
>
> Gast�n Kleiman
>
>
Re: Review Request 55676: Moved `getRootContainerId` to
`protobuf_utils`.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55676/#review162285
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 19, 2017, 10:15 a.m., Gast�n Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55676/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2017, 10:15 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, Alexander Rojas, haosdent huang, and Vinod Kone.
>
>
> Bugs: MESOS-6864
> https://issues.apache.org/jira/browse/MESOS-6864
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This method is pretty generic and should not be a part of the Mesos
> containerizer code.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp bca9ace6cb37047bb08466c4fb14028bbb818446
> src/common/protobuf_utils.cpp af3c2a660f91c366ca5ffe8671d10c4a270bbbcc
> src/slave/containerizer/composing.cpp 4fb7ba5cadd36be00be61aa00a69c38c44649aee
> src/slave/containerizer/mesos/containerizer.cpp 8bf8a7774a38131c53f6d91c7f09f5dedd9d4cb4
> src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp b3a269535517222a1d85d8be1fdf5b865d6a3fc6
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp e1cac954848e618a03ddb82fd6d040ae1d948e82
> src/slave/containerizer/mesos/utils.hpp a54106dc4893bb222f42ede936ac9029e817faf9
> src/slave/containerizer/mesos/utils.cpp 4e2a01495909c07f320af416ff4dc59f7328c710
>
> Diff: https://reviews.apache.org/r/55676/diff/
>
>
> Testing
> -------
>
> `make check` in macOS and Linux.
>
>
> Thanks,
>
> Gast�n Kleiman
>
>
Re: Review Request 55676: Moved `getRootContainerId` to
`protobuf_utils`.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55676/#review162291
-----------------------------------------------------------
Ship it!
src/slave/containerizer/mesos/containerizer.cpp (line 749)
<https://reviews.apache.org/r/55676/#comment233624>
Not yours, we don't capture temporaries by const reference as per our style guide. You might want to clean this up in a separate patch.
- Anand Mazumdar
On Jan. 19, 2017, 10:15 a.m., Gast�n Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55676/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2017, 10:15 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, Alexander Rojas, haosdent huang, and Vinod Kone.
>
>
> Bugs: MESOS-6864
> https://issues.apache.org/jira/browse/MESOS-6864
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This method is pretty generic and should not be a part of the Mesos
> containerizer code.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp bca9ace6cb37047bb08466c4fb14028bbb818446
> src/common/protobuf_utils.cpp af3c2a660f91c366ca5ffe8671d10c4a270bbbcc
> src/slave/containerizer/composing.cpp 4fb7ba5cadd36be00be61aa00a69c38c44649aee
> src/slave/containerizer/mesos/containerizer.cpp 8bf8a7774a38131c53f6d91c7f09f5dedd9d4cb4
> src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp b3a269535517222a1d85d8be1fdf5b865d6a3fc6
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp e1cac954848e618a03ddb82fd6d040ae1d948e82
> src/slave/containerizer/mesos/utils.hpp a54106dc4893bb222f42ede936ac9029e817faf9
> src/slave/containerizer/mesos/utils.cpp 4e2a01495909c07f320af416ff4dc59f7328c710
>
> Diff: https://reviews.apache.org/r/55676/diff/
>
>
> Testing
> -------
>
> `make check` in macOS and Linux.
>
>
> Thanks,
>
> Gast�n Kleiman
>
>
Re: Review Request 55676: Moved `getRootContainerId` to
`protobuf_utils`.
Posted by Gastón Kleiman <ga...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55676/
-----------------------------------------------------------
(Updated Jan. 19, 2017, 10:15 a.m.)
Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, Alexander Rojas, haosdent huang, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-6864
https://issues.apache.org/jira/browse/MESOS-6864
Repository: mesos
Description
-------
This method is pretty generic and should not be a part of the Mesos
containerizer code.
Diffs (updated)
-----
src/common/protobuf_utils.hpp bca9ace6cb37047bb08466c4fb14028bbb818446
src/common/protobuf_utils.cpp af3c2a660f91c366ca5ffe8671d10c4a270bbbcc
src/slave/containerizer/composing.cpp 4fb7ba5cadd36be00be61aa00a69c38c44649aee
src/slave/containerizer/mesos/containerizer.cpp 8bf8a7774a38131c53f6d91c7f09f5dedd9d4cb4
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp b3a269535517222a1d85d8be1fdf5b865d6a3fc6
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp e1cac954848e618a03ddb82fd6d040ae1d948e82
src/slave/containerizer/mesos/utils.hpp a54106dc4893bb222f42ede936ac9029e817faf9
src/slave/containerizer/mesos/utils.cpp 4e2a01495909c07f320af416ff4dc59f7328c710
Diff: https://reviews.apache.org/r/55676/diff/
Testing
-------
`make check` in macOS and Linux.
Thanks,
Gast�n Kleiman
Re: Review Request 55676: Moved `getRootContainerId` to
`protobuf_utils`.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55676/#review162266
-----------------------------------------------------------
src/slave/slave.cpp
<https://reviews.apache.org/r/55676/#comment233609>
Rebase problem?
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/55676/#comment233610>
Rebase problem?
- Alexander Rojas
On Jan. 18, 2017, 8:01 p.m., Gast�n Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55676/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 8:01 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, Alexander Rojas, haosdent huang, and Vinod Kone.
>
>
> Bugs: MESOS-6864
> https://issues.apache.org/jira/browse/MESOS-6864
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This method is pretty generic and should not be a part of the Mesos
> containerizer code.
>
>
> Diffs
> -----
>
> CHANGELOG a8d080555a3948c796116af90c17dd71e1dea5d2
> src/common/protobuf_utils.hpp bca9ace6cb37047bb08466c4fb14028bbb818446
> src/common/protobuf_utils.cpp af3c2a660f91c366ca5ffe8671d10c4a270bbbcc
> src/slave/containerizer/composing.cpp 4fb7ba5cadd36be00be61aa00a69c38c44649aee
> src/slave/containerizer/mesos/containerizer.cpp 8bf8a7774a38131c53f6d91c7f09f5dedd9d4cb4
> src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp b3a269535517222a1d85d8be1fdf5b865d6a3fc6
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp e1cac954848e618a03ddb82fd6d040ae1d948e82
> src/slave/containerizer/mesos/utils.hpp a54106dc4893bb222f42ede936ac9029e817faf9
> src/slave/containerizer/mesos/utils.cpp 4e2a01495909c07f320af416ff4dc59f7328c710
> src/slave/slave.cpp 205138add7a63289ff8ed81138f8b603828c748e
> src/tests/slave_recovery_tests.cpp 9cf1d461cf5c6ac1f51ac963360a17e37f558505
>
> Diff: https://reviews.apache.org/r/55676/diff/
>
>
> Testing
> -------
>
> `make check` in macOS and Linux.
>
>
> Thanks,
>
> Gast�n Kleiman
>
>