Tiles build broken

[jeff <je...@socialchange.net.au>]

Hi,

There are problems with Tiles' build system that prevent it from building from
Struts root. Because Struts' 'dist' target depends on Tiles, the Struts build
system is effectively broken too.

Tiles fails to build because it can't find a library:

init:
     [echo] --------- Tiles 1.1-dev ---------
     [echo] 
     [echo] java.class.path = /usr/lib/j2sdk1.3/lib/tools.jar:/usr/lib/j2re1.3/lib/rt.jar::/usr/local/ant/lib/ant.jar:/usr/local/ant/lib/jakarta-regexp-1.3-dev.jar:/usr/local/ant/lib/junit-3.7.jar:/usr/local/ant/lib/optional.jar:/usr/local/ant/lib/w3cdom2.jar:/usr/local/ant/lib/xalan-2.2.0-D8.jar:/usr/local/ant/lib/xerces.jar:/usr/lib/j2sdk1.3/lib/tools.jar
     [echo] java.home = /usr/lib/j2re1.3
     [echo] user.home = /home/jeff
     [echo] struts.home     = target/library
     [echo] struts.libs     = ../../target/library
     [echo] dist.home       = ../../dist
     [echo] build.home      = ../../target/tiles
     [echo] basedir         = /home/jeff/apache/jakarta/jakarta-struts/contrib/tiles
compile.library:
    [javac] Compiling 41 source files to /home/jeff/apache/jakarta/jakarta-struts/target/tiles/library/classes
    [javac] /home/jeff/apache/jakarta/jakarta-struts/contrib/tiles/src/share/org/apache/struts/taglib/tiles/ext/TextTag.java:70: cannot resolve symbol
    [javac] symbol  : class JspException  
    [javac] location: package jsp
    [javac] import javax.servlet.jsp.JspException;
...

It can't find servlet.jar because:
 - it inherits the "servlet.jar" property from the main struts build-webapps.xml
 - in build.properties, it is specified as relative:

servlet.jar=../jakarta-servletapi/lib/servlet.jar

   This works for Struts, but not for Tiles (in a subdir), where the relative
   reference breaks.

Changing that to:

servlet.jar=${basedir}/../jakarta-servletapi/lib/servlet.jar

   gets Tiles sort-of compiling. The docs and javadocs still won't build:

compile:
    [style] DEPRECATED - the style attribute should be relative to the project's
    [style]              basedir, not the tasks's basedir.
    [style] Transforming into /home/jeff/apache/jakarta/jakarta-struts/target/tiles/documentation/doc
    [style] Transforming into /home/jeff/apache/jakarta/jakarta-struts/target/tiles/documentation/doc
    [style] Loading stylesheet /home/jeff/apache/jakarta/jakarta-struts/contrib/tiles/doc/stylesheets/struts.xsl
    [style] org.apache.xml.utils.WrappedRuntimeException: File "file:////home/jeff/apache/jakarta/jakarta-struts/contrib/tiles/doc/project.xml" not found.


compile.javadoc:
...
  [javadoc] /home/jeff/apache/jakarta/jakarta-struts/src/share/org/apache/struts/action/ActionServlet.java:83: Class org.apache.commons.collections.FastHashMap not found in import.
  [javadoc] import org.apache.commons.collections.FastHashMap;
  [javadoc]        ^