You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2019/12/04 00:46:44 UTC

[kudu-CR] [java] KUDU-1644 Simplify IN-list predicate values during token building

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14706 )

Change subject: [java] KUDU-1644 Simplify IN-list predicate values during token building
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14706/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14706/5//COMMIT_MSG@14
PS5, Line 14: when building the scanner.
why not do this on the server side? then you get it for free in both C++ and Java clients. The server side of the tablet should already know its partitioning information.



-- 
To view, visit http://gerrit.cloudera.org:8080/14706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I05affbd10804b4d07478f7abdde5380dd70ec116
Gerrit-Change-Number: 14706
Gerrit-PatchSet: 5
Gerrit-Owner: wangning <19...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 04 Dec 2019 00:46:44 +0000
Gerrit-HasComments: Yes