You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "metatype (GitHub)" <gi...@apache.org> on 2018/11/03 00:11:40 UTC
[GitHub] [geode-native] metatype opened pull request #391: GEODE-5968
Updated missing source headers
Remove BOM so that rat can check for correct headers. Add cotire
reference to LICENSE since it is included in the source and under
an MIT license.
[ Full content available at: https://github.com/apache/geode-native/pull/391 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on pull request
#391: GEODE-5968 Updated missing source headers
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Can you explain why something like Cotire would be included in the LICENSE file? It is used only at build time. Is it because it will be shipped in source form with the source distribution?
[ Full content available at: https://github.com/apache/geode-native/pull/391 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] metatype commented on pull request #391:
GEODE-5968 Updated missing source headers
Posted by "metatype (GitHub)" <gi...@apache.org>.
Yep, the GitHub review doesn't show the control chars.
[ Full content available at: https://github.com/apache/geode-native/pull/391 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] metatype closed pull request #391: GEODE-5968
Updated missing source headers
Posted by "metatype (GitHub)" <gi...@apache.org>.
[ pull request closed by metatype ]
[ Full content available at: https://github.com/apache/geode-native/pull/391 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on pull request
#391: GEODE-5968 Updated missing source headers
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Would it be preferable to change the source to fetch Cotire from GitHub when PCH is enabled at configure time?
[ Full content available at: https://github.com/apache/geode-native/pull/391 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] metatype commented on pull request #391:
GEODE-5968 Updated missing source headers
Posted by "metatype (GitHub)" <gi...@apache.org>.
Exactly. The LICENSE file needs to declare things that are bundled in the release (the source distribution). If we choose to provide a convenience binary, there would be a second LICENSE file that also includes any bundled binary dependencies.
[ Full content available at: https://github.com/apache/geode-native/pull/391 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] metatype commented on pull request #391:
GEODE-5968 Updated missing source headers
Posted by "metatype (GitHub)" <gi...@apache.org>.
Either way is fine in this case. If the bundled dependency were Category X (e.g. GPL) you would need take the optional download approach.
[ Full content available at: https://github.com/apache/geode-native/pull/391 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on pull request
#391: GEODE-5968 Updated missing source headers
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Were these all BOM issues?
[ Full content available at: https://github.com/apache/geode-native/pull/391 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org