[jira] [Commented] (FLINK-4155) Get Kafka producer partition info in open method instead of constructor

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15683507#comment-15683507 ] 

ASF GitHub Bot commented on FLINK-4155:
---------------------------------------

Github user rmetzger commented on the issue:

    https://github.com/apache/flink/pull/2681
  
    Did you refactor the table tests? If not, we can also merge this PR as is and file a follow up JIRA.
    One other thing I thought about while looking over the PR: We need the partition list only for the partitioner.
    So we actually need to do the getPartitions() call only if a partitioner has been set.
    
    The PR is +1 to merge. Its up to you if you are doing the getPartition() call conditional with the PR, or whether we do it in a separate PR.


> Get Kafka producer partition info in open method instead of constructor
> -----------------------------------------------------------------------
>
>                 Key: FLINK-4155
>                 URL: https://issues.apache.org/jira/browse/FLINK-4155
>             Project: Flink
>          Issue Type: Bug
>          Components: Kafka Connector
>    Affects Versions: 1.1.0, 1.0.3
>            Reporter: Gyula Fora
>            Assignee: Tzu-Li (Gordon) Tai
>             Fix For: 1.2.0
>
>
> Currently the Flink Kafka producer does not really do any error handling if something is wrong with the partition metadata as it is serialized with the user function.
> This means that in some cases the job can go into an error loop when using the checkpoints. Getting the partition info in the open method would solve this problem (like restarting from a savepoint which re-runs the constructor).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)