You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jimmy Xiang (JIRA)" <ji...@apache.org> on 2012/08/01 02:08:33 UTC

[jira] [Created] (HBASE-6487) assign region doesn't check if the region is already assigned

Jimmy Xiang created HBASE-6487:
----------------------------------

             Summary: assign region doesn't check if the region is already assigned
                 Key: HBASE-6487
                 URL: https://issues.apache.org/jira/browse/HBASE-6487
             Project: HBase
          Issue Type: Bug
            Reporter: Jimmy Xiang


Tried to assign a region already assigned somewhere from hbase shell, the region is assigned to a different place but the previous assignment is not closed.  So it causes double assignments.  In such a case, it's better to issue a warning instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6487) assign region doesn't check if the region is already assigned

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437126#comment-13437126 ] 

Hudson commented on HBASE-6487:
-------------------------------

Integrated in HBase-TRUNK #3236 (See [https://builds.apache.org/job/HBase-TRUNK/3236/])
    HBASE-6487 assign region doesn't check if the region is already assigned -- REVERTED (Revision 1374452)

     Result = FAILURE
jxiang : 
Files : 
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStates.java
* /hbase/trunk/hbase-server/src/main/ruby/shell/commands/assign.rb

                
> assign region doesn't check if the region is already assigned
> -------------------------------------------------------------
>
>                 Key: HBASE-6487
>                 URL: https://issues.apache.org/jira/browse/HBASE-6487
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: trunk-6487.patch, trunk-6487_v2.patch
>
>
> Tried to assign a region already assigned somewhere from hbase shell, the region is assigned to a different place but the previous assignment is not closed.  So it causes double assignments.  In such a case, it's better to issue a warning instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Reopened] (HBASE-6487) assign region doesn't check if the region is already assigned

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang reopened HBASE-6487:
--------------------------------


Reverted. TestHBaseFsck is broken
                
> assign region doesn't check if the region is already assigned
> -------------------------------------------------------------
>
>                 Key: HBASE-6487
>                 URL: https://issues.apache.org/jira/browse/HBASE-6487
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: trunk-6487.patch, trunk-6487_v2.patch
>
>
> Tried to assign a region already assigned somewhere from hbase shell, the region is assigned to a different place but the previous assignment is not closed.  So it causes double assignments.  In such a case, it's better to issue a warning instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6487) assign region doesn't check if the region is already assigned

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435761#comment-13435761 ] 

ramkrishna.s.vasudevan commented on HBASE-6487:
-----------------------------------------------

@Jimmy
Are you going to commit this ?
                
> assign region doesn't check if the region is already assigned
> -------------------------------------------------------------
>
>                 Key: HBASE-6487
>                 URL: https://issues.apache.org/jira/browse/HBASE-6487
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: trunk-6487.patch, trunk-6487_v2.patch
>
>
> Tried to assign a region already assigned somewhere from hbase shell, the region is assigned to a different place but the previous assignment is not closed.  So it causes double assignments.  In such a case, it's better to issue a warning instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6487) assign region doesn't check if the region is already assigned

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427104#comment-13427104 ] 

ramkrishna.s.vasudevan commented on HBASE-6487:
-----------------------------------------------

@Jimmy
Can we also if something is in transition also here? Because internally in one of our code we are trying to use RIT also as a check?
                
> assign region doesn't check if the region is already assigned
> -------------------------------------------------------------
>
>                 Key: HBASE-6487
>                 URL: https://issues.apache.org/jira/browse/HBASE-6487
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: trunk-6487.patch
>
>
> Tried to assign a region already assigned somewhere from hbase shell, the region is assigned to a different place but the previous assignment is not closed.  So it causes double assignments.  In such a case, it's better to issue a warning instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6487) assign region doesn't check if the region is already assigned

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429353#comment-13429353 ] 

Hadoop QA commented on HBASE-6487:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12539326/trunk-6487_v2.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).

    -1 findbugs.  The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.replication.TestReplication
                  org.apache.hadoop.hbase.util.TestHBaseFsck

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2522//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2522//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2522//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2522//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2522//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2522//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2522//console

This message is automatically generated.
                
> assign region doesn't check if the region is already assigned
> -------------------------------------------------------------
>
>                 Key: HBASE-6487
>                 URL: https://issues.apache.org/jira/browse/HBASE-6487
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: trunk-6487.patch, trunk-6487_v2.patch
>
>
> Tried to assign a region already assigned somewhere from hbase shell, the region is assigned to a different place but the previous assignment is not closed.  So it causes double assignments.  In such a case, it's better to issue a warning instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6487) assign region doesn't check if the region is already assigned

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-6487:
-------------------------------

    Status: Patch Available  (was: Open)
    
> assign region doesn't check if the region is already assigned
> -------------------------------------------------------------
>
>                 Key: HBASE-6487
>                 URL: https://issues.apache.org/jira/browse/HBASE-6487
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>         Attachments: trunk-6487.patch
>
>
> Tried to assign a region already assigned somewhere from hbase shell, the region is assigned to a different place but the previous assignment is not closed.  So it causes double assignments.  In such a case, it's better to issue a warning instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (HBASE-6487) assign region doesn't check if the region is already assigned

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang resolved HBASE-6487.
--------------------------------

    Resolution: Won't Fix

Won't fix.  Hbck test uses it a lot to create inconsistencies.
It is meant for advanced use any way.
                
> assign region doesn't check if the region is already assigned
> -------------------------------------------------------------
>
>                 Key: HBASE-6487
>                 URL: https://issues.apache.org/jira/browse/HBASE-6487
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: trunk-6487.patch, trunk-6487_v2.patch
>
>
> Tried to assign a region already assigned somewhere from hbase shell, the region is assigned to a different place but the previous assignment is not closed.  So it causes double assignments.  In such a case, it's better to issue a warning instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6487) assign region doesn't check if the region is already assigned

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-6487:
-------------------------------

    Status: Open  (was: Patch Available)
    
> assign region doesn't check if the region is already assigned
> -------------------------------------------------------------
>
>                 Key: HBASE-6487
>                 URL: https://issues.apache.org/jira/browse/HBASE-6487
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: trunk-6487.patch
>
>
> Tried to assign a region already assigned somewhere from hbase shell, the region is assigned to a different place but the previous assignment is not closed.  So it causes double assignments.  In such a case, it's better to issue a warning instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6487) assign region doesn't check if the region is already assigned

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436072#comment-13436072 ] 

Jimmy Xiang commented on HBASE-6487:
------------------------------------

@Stack, are you ok for the patch? I think it is good even if OFFLINE state is not so trustful. It's better not to double assign.

                
> assign region doesn't check if the region is already assigned
> -------------------------------------------------------------
>
>                 Key: HBASE-6487
>                 URL: https://issues.apache.org/jira/browse/HBASE-6487
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: trunk-6487.patch, trunk-6487_v2.patch
>
>
> Tried to assign a region already assigned somewhere from hbase shell, the region is assigned to a different place but the previous assignment is not closed.  So it causes double assignments.  In such a case, it's better to issue a warning instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6487) assign region doesn't check if the region is already assigned

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427444#comment-13427444 ] 

Jimmy Xiang commented on HBASE-6487:
------------------------------------

Sure.  How about just checking the region state and make sure it is OFFLINE?  If it is in other states, the region should be either opened or in transition, right?
                
> assign region doesn't check if the region is already assigned
> -------------------------------------------------------------
>
>                 Key: HBASE-6487
>                 URL: https://issues.apache.org/jira/browse/HBASE-6487
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: trunk-6487.patch
>
>
> Tried to assign a region already assigned somewhere from hbase shell, the region is assigned to a different place but the previous assignment is not closed.  So it causes double assignments.  In such a case, it's better to issue a warning instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6487) assign region doesn't check if the region is already assigned

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437093#comment-13437093 ] 

Hudson commented on HBASE-6487:
-------------------------------

Integrated in HBase-TRUNK #3235 (See [https://builds.apache.org/job/HBase-TRUNK/3235/])
    HBASE-6487 assign region doesn't check if the region is already assigned (Revision 1374423)

     Result = FAILURE
jxiang : 
Files : 
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStates.java
* /hbase/trunk/hbase-server/src/main/ruby/shell/commands/assign.rb

                
> assign region doesn't check if the region is already assigned
> -------------------------------------------------------------
>
>                 Key: HBASE-6487
>                 URL: https://issues.apache.org/jira/browse/HBASE-6487
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: trunk-6487.patch, trunk-6487_v2.patch
>
>
> Tried to assign a region already assigned somewhere from hbase shell, the region is assigned to a different place but the previous assignment is not closed.  So it causes double assignments.  In such a case, it's better to issue a warning instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6487) assign region doesn't check if the region is already assigned

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433224#comment-13433224 ] 

stack commented on HBASE-6487:
------------------------------

getAssignedServer is not used by this patch?  Its added by this patch but then not used.

This patch will work if OFFLINE state can be trusted (it should be more reliable after hbase-6060?)
                
> assign region doesn't check if the region is already assigned
> -------------------------------------------------------------
>
>                 Key: HBASE-6487
>                 URL: https://issues.apache.org/jira/browse/HBASE-6487
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: trunk-6487.patch, trunk-6487_v2.patch
>
>
> Tried to assign a region already assigned somewhere from hbase shell, the region is assigned to a different place but the previous assignment is not closed.  So it causes double assignments.  In such a case, it's better to issue a warning instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6487) assign region doesn't check if the region is already assigned

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-6487:
-------------------------------

    Attachment: trunk-6487.patch
    
> assign region doesn't check if the region is already assigned
> -------------------------------------------------------------
>
>                 Key: HBASE-6487
>                 URL: https://issues.apache.org/jira/browse/HBASE-6487
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>         Attachments: trunk-6487.patch
>
>
> Tried to assign a region already assigned somewhere from hbase shell, the region is assigned to a different place but the previous assignment is not closed.  So it causes double assignments.  In such a case, it's better to issue a warning instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6487) assign region doesn't check if the region is already assigned

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-6487:
-------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Thanks all.  Integrated to trunk.
                
> assign region doesn't check if the region is already assigned
> -------------------------------------------------------------
>
>                 Key: HBASE-6487
>                 URL: https://issues.apache.org/jira/browse/HBASE-6487
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: trunk-6487.patch, trunk-6487_v2.patch
>
>
> Tried to assign a region already assigned somewhere from hbase shell, the region is assigned to a different place but the previous assignment is not closed.  So it causes double assignments.  In such a case, it's better to issue a warning instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6487) assign region doesn't check if the region is already assigned

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-6487:
-------------------------------

    Status: Patch Available  (was: Open)
    
> assign region doesn't check if the region is already assigned
> -------------------------------------------------------------
>
>                 Key: HBASE-6487
>                 URL: https://issues.apache.org/jira/browse/HBASE-6487
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: trunk-6487.patch, trunk-6487_v2.patch
>
>
> Tried to assign a region already assigned somewhere from hbase shell, the region is assigned to a different place but the previous assignment is not closed.  So it causes double assignments.  In such a case, it's better to issue a warning instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6487) assign region doesn't check if the region is already assigned

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-6487:
-------------------------------

    Attachment: trunk-6487_v2.patch
    
> assign region doesn't check if the region is already assigned
> -------------------------------------------------------------
>
>                 Key: HBASE-6487
>                 URL: https://issues.apache.org/jira/browse/HBASE-6487
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: trunk-6487.patch, trunk-6487_v2.patch
>
>
> Tried to assign a region already assigned somewhere from hbase shell, the region is assigned to a different place but the previous assignment is not closed.  So it causes double assignments.  In such a case, it's better to issue a warning instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6487) assign region doesn't check if the region is already assigned

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436880#comment-13436880 ] 

stack commented on HBASE-6487:
------------------------------

+1 on commit
                
> assign region doesn't check if the region is already assigned
> -------------------------------------------------------------
>
>                 Key: HBASE-6487
>                 URL: https://issues.apache.org/jira/browse/HBASE-6487
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: trunk-6487.patch, trunk-6487_v2.patch
>
>
> Tried to assign a region already assigned somewhere from hbase shell, the region is assigned to a different place but the previous assignment is not closed.  So it causes double assignments.  In such a case, it's better to issue a warning instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6487) assign region doesn't check if the region is already assigned

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-6487:
-------------------------------

    Priority: Minor  (was: Major)
    Assignee: Jimmy Xiang
    
> assign region doesn't check if the region is already assigned
> -------------------------------------------------------------
>
>                 Key: HBASE-6487
>                 URL: https://issues.apache.org/jira/browse/HBASE-6487
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>
> Tried to assign a region already assigned somewhere from hbase shell, the region is assigned to a different place but the previous assignment is not closed.  So it causes double assignments.  In such a case, it's better to issue a warning instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6487) assign region doesn't check if the region is already assigned

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433366#comment-13433366 ] 

Jimmy Xiang commented on HBASE-6487:
------------------------------------

getAssignedServer is used for the first patch.  It is not used for the second one.  I thought it is useful so I kept it there. I can remove if we prefer to.

Yes, it will be more reliable after HBASE-6060.
                
> assign region doesn't check if the region is already assigned
> -------------------------------------------------------------
>
>                 Key: HBASE-6487
>                 URL: https://issues.apache.org/jira/browse/HBASE-6487
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: trunk-6487.patch, trunk-6487_v2.patch
>
>
> Tried to assign a region already assigned somewhere from hbase shell, the region is assigned to a different place but the previous assignment is not closed.  So it causes double assignments.  In such a case, it's better to issue a warning instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6487) assign region doesn't check if the region is already assigned

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433023#comment-13433023 ] 

ramkrishna.s.vasudevan commented on HBASE-6487:
-----------------------------------------------

So as per the patch we will only check if any region is in RIT (ie if it is in anyother state other than OFFLINE).  If so skip the assignment.  If not carry on.
Makes sense.  Thanks for the patch Jimmy. +1


                
> assign region doesn't check if the region is already assigned
> -------------------------------------------------------------
>
>                 Key: HBASE-6487
>                 URL: https://issues.apache.org/jira/browse/HBASE-6487
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: trunk-6487.patch, trunk-6487_v2.patch
>
>
> Tried to assign a region already assigned somewhere from hbase shell, the region is assigned to a different place but the previous assignment is not closed.  So it causes double assignments.  In such a case, it's better to issue a warning instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6487) assign region doesn't check if the region is already assigned

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426776#comment-13426776 ] 

Jimmy Xiang commented on HBASE-6487:
------------------------------------

Changed to Minor since it is a known issue:

Assign a region.Use with caution.If region already assigned,
this command will just go ahead and reassign
the region anyways. For experts only.
                
> assign region doesn't check if the region is already assigned
> -------------------------------------------------------------
>
>                 Key: HBASE-6487
>                 URL: https://issues.apache.org/jira/browse/HBASE-6487
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>
> Tried to assign a region already assigned somewhere from hbase shell, the region is assigned to a different place but the previous assignment is not closed.  So it causes double assignments.  In such a case, it's better to issue a warning instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6487) assign region doesn't check if the region is already assigned

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-6487:
-------------------------------

    Fix Version/s: 0.96.0
    
> assign region doesn't check if the region is already assigned
> -------------------------------------------------------------
>
>                 Key: HBASE-6487
>                 URL: https://issues.apache.org/jira/browse/HBASE-6487
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: trunk-6487.patch
>
>
> Tried to assign a region already assigned somewhere from hbase shell, the region is assigned to a different place but the previous assignment is not closed.  So it causes double assignments.  In such a case, it's better to issue a warning instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira