You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Florian Barca <fb...@hortonworks.com> on 2015/05/18 13:50:07 UTC
Review Request 34346: [WinTP2] Ambari Agent fails to start
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34346/
-----------------------------------------------------------
Review request for Ambari, Artem Baranchuk, Andrew Onischuk, Eugene Chekanskiy, and Jayush Luniya.
Bugs: AMBARI-11206
https://issues.apache.org/jira/browse/AMBARI-11206
Repository: ambari
Description
-------
Fixed Windows-specific chown-like routines
Diffs
-----
ambari-common/src/main/python/resource_management/core/sudo.py b5dfa478f5f2ea4bffd5ab0ffccfc716226ca7dc
ambari-common/src/main/python/resource_management/core/utils.py f9ad193b1c8b3cc4b87e4df585a5bb77d0921d0d
Diff: https://reviews.apache.org/r/34346/diff/
Testing
-------
mvn clean test
deployment -> agent starts ok
Thanks,
Florian Barca
Re: Review Request 34346: [WinTP2] Ambari Agent fails to start
Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34346/#review84140
-----------------------------------------------------------
Ship it!
Ship It!
- Artem Baranchuk
On Май 18, 2015, 12:28 п.п., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34346/
> -----------------------------------------------------------
>
> (Updated Май 18, 2015, 12:28 п.п.)
>
>
> Review request for Ambari, Artem Baranchuk, Andrew Onischuk, Eugene Chekanskiy, and Jayush Luniya.
>
>
> Bugs: AMBARI-11206
> https://issues.apache.org/jira/browse/AMBARI-11206
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fixed Windows-specific chown-like routines
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/core/source.py 73174922fd8df5bc7eb50bcc3c7a349ae4f26a8c
> ambari-common/src/main/python/resource_management/core/sudo.py b5dfa478f5f2ea4bffd5ab0ffccfc716226ca7dc
>
> Diff: https://reviews.apache.org/r/34346/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> deployment -> agent starts ok
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 34346: [WinTP2] Ambari Agent fails to start
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34346/#review84139
-----------------------------------------------------------
Ship it!
Looks neat thanks!
- Andrew Onischuk
On May 18, 2015, 12:28 p.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34346/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 12:28 p.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Andrew Onischuk, Eugene Chekanskiy, and Jayush Luniya.
>
>
> Bugs: AMBARI-11206
> https://issues.apache.org/jira/browse/AMBARI-11206
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fixed Windows-specific chown-like routines
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/core/source.py 73174922fd8df5bc7eb50bcc3c7a349ae4f26a8c
> ambari-common/src/main/python/resource_management/core/sudo.py b5dfa478f5f2ea4bffd5ab0ffccfc716226ca7dc
>
> Diff: https://reviews.apache.org/r/34346/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> deployment -> agent starts ok
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 34346: [WinTP2] Ambari Agent fails to start
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34346/
-----------------------------------------------------------
(Updated May 18, 2015, 12:28 p.m.)
Review request for Ambari, Artem Baranchuk, Andrew Onischuk, Eugene Chekanskiy, and Jayush Luniya.
Changes
-------
Reinstated the Windows-specific read_file()
Bugs: AMBARI-11206
https://issues.apache.org/jira/browse/AMBARI-11206
Repository: ambari
Description
-------
Fixed Windows-specific chown-like routines
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/core/source.py 73174922fd8df5bc7eb50bcc3c7a349ae4f26a8c
ambari-common/src/main/python/resource_management/core/sudo.py b5dfa478f5f2ea4bffd5ab0ffccfc716226ca7dc
Diff: https://reviews.apache.org/r/34346/diff/
Testing
-------
mvn clean test
deployment -> agent starts ok
Thanks,
Florian Barca
Re: Review Request 34346: [WinTP2] Ambari Agent fails to start
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34346/#review84136
-----------------------------------------------------------
This breaks linux installs
- Andrew Onischuk
On May 18, 2015, 11:50 a.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34346/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 11:50 a.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Andrew Onischuk, Eugene Chekanskiy, and Jayush Luniya.
>
>
> Bugs: AMBARI-11206
> https://issues.apache.org/jira/browse/AMBARI-11206
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fixed Windows-specific chown-like routines
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/core/sudo.py b5dfa478f5f2ea4bffd5ab0ffccfc716226ca7dc
> ambari-common/src/main/python/resource_management/core/utils.py f9ad193b1c8b3cc4b87e4df585a5bb77d0921d0d
>
> Diff: https://reviews.apache.org/r/34346/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> deployment -> agent starts ok
>
>
> Thanks,
>
> Florian Barca
>
>