You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Polber (via GitHub)" <gi...@apache.org> on 2024/03/29 22:14:36 UTC

[PR] Propagate display_data to Job proto [beam]

Polber opened a new pull request, #30809:
URL: https://github.com/apache/beam/pull/30809

   `display_data` was not being propagated to Job proto in Python SDK.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Propagate display_data to Job proto [beam]

Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb commented on code in PR #30809:
URL: https://github.com/apache/beam/pull/30809#discussion_r1544920503


##########
sdks/python/apache_beam/pipeline.py:
##########
@@ -584,7 +585,8 @@ def run(self, test_runner_api='AUTO'):
           pickler.dump_session(os.path.join(tmpdir, 'main_session.pickle'))
         finally:
           shutil.rmtree(tmpdir)
-      return self.runner.run_pipeline(self, self._options)
+      return self.runner.run_pipeline(
+          self, self._options, display_data=display_data)

Review Comment:
   We should probably avoid changing the signature of Runner.run_pipeline(...)



##########
sdks/python/apache_beam/runners/dataflow/dataflow_runner.py:
##########
@@ -466,7 +467,8 @@ def run_pipeline(self, pipeline, options, pipeline_proto=None):
       debug_options.add_experiment(
           'min_cpu_platform=' + worker_options.min_cpu_platform)
 
-    self.job = apiclient.Job(options, self.proto_pipeline)
+    self.job = apiclient.Job(
+        options, self.proto_pipeline, display_data=display_data)

Review Comment:
   same



##########
sdks/python/apache_beam/runners/dataflow/dataflow_runner.py:
##########
@@ -331,7 +331,8 @@ def _adjust_pipeline_for_dataflow_v2(self, pipeline):
             not pipeline._options.view_as(
                 TypeOptions).allow_non_deterministic_key_coders))
 
-  def run_pipeline(self, pipeline, options, pipeline_proto=None):
+  def run_pipeline(
+      self, pipeline, options, pipeline_proto=None, display_data=None):

Review Comment:
   Should display_data be present on pipeline and/or pipeline_proto, rather than requiring we pass it separately?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Propagate display_data to Job proto [beam]

Posted by "Polber (via GitHub)" <gi...@apache.org>.
Polber closed pull request #30809: Propagate display_data to Job proto
URL: https://github.com/apache/beam/pull/30809


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org