You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by le...@apache.org on 2023/01/01 09:58:39 UTC
svn commit: r1906308 - in /pdfbox/trunk/io/src: main/java/org/apache/pdfbox/io/ScratchFileBuffer.java test/java/org/apache/pdfbox/io/ScratchFileBufferTest.java
Author: lehmi
Date: Sun Jan 1 09:58:39 2023
New Revision: 1906308
URL: http://svn.apache.org/viewvc?rev=1906308&view=rev
Log:
PDFBOX-4836: remove support for views from ScratchFileBuffer
Modified:
pdfbox/trunk/io/src/main/java/org/apache/pdfbox/io/ScratchFileBuffer.java
pdfbox/trunk/io/src/test/java/org/apache/pdfbox/io/ScratchFileBufferTest.java
Modified: pdfbox/trunk/io/src/main/java/org/apache/pdfbox/io/ScratchFileBuffer.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/io/src/main/java/org/apache/pdfbox/io/ScratchFileBuffer.java?rev=1906308&r1=1906307&r2=1906308&view=diff
==============================================================================
--- pdfbox/trunk/io/src/main/java/org/apache/pdfbox/io/ScratchFileBuffer.java (original)
+++ pdfbox/trunk/io/src/main/java/org/apache/pdfbox/io/ScratchFileBuffer.java Sun Jan 1 09:58:39 2023
@@ -446,7 +446,8 @@ class ScratchFileBuffer implements Rando
@Override
public RandomAccessReadView createView(long startPosition, long streamLength) throws IOException
{
- return new RandomAccessReadView(this, startPosition, streamLength);
+ throw new UnsupportedOperationException(
+ getClass().getName() + ".createView isn't supported.");
}
}
Modified: pdfbox/trunk/io/src/test/java/org/apache/pdfbox/io/ScratchFileBufferTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/io/src/test/java/org/apache/pdfbox/io/ScratchFileBufferTest.java?rev=1906308&r1=1906307&r2=1906308&view=diff
==============================================================================
--- pdfbox/trunk/io/src/test/java/org/apache/pdfbox/io/ScratchFileBufferTest.java (original)
+++ pdfbox/trunk/io/src/test/java/org/apache/pdfbox/io/ScratchFileBufferTest.java Sun Jan 1 09:58:39 2023
@@ -158,14 +158,8 @@ class ScratchFileBufferTest
RandomAccess scratchFileBuffer = scratchFile.createBuffer();
byte[] inputValues = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 };
scratchFileBuffer.write(inputValues);
- try (RandomAccessReadView view = scratchFileBuffer.createView(3, 5))
- {
- assertEquals(0, view.getPosition());
- assertEquals(3, view.read());
- assertEquals(4, view.read());
- assertEquals(5, view.read());
- assertEquals(3, view.getPosition());
- }
+ assertThrows(UnsupportedOperationException.class,
+ () -> scratchFileBuffer.createView(0, 10));
}
}