[GitHub] [pinot] jackjlli commented on pull request #7590: Reject query with identifiers not in schema

[GitBox <gi...@apache.org>]

jackjlli commented on pull request #7590:
URL: https://github.com/apache/pinot/pull/7590#issuecomment-952439552


   > > I actually have two PRs for this: #6066 #6361
   > > And I don't think it's a good to directly throwing a bad query exception as it will immediately impact the existing use cases which have already been using invalid columns in their query pattern.
   > 
   > Didn't realize the previous works here. The changes for this PR is similar to #6066 to check on broker side to reject identifiers based on table schema.
   > 
   > For backward compatibility, we don't need to keep the behavior for invalid queries. It's better to show them the failure other than return 0 silently.
   
   This PR can definitely bring in backward incompatibility as it changes the existing behavior of handling invalid columns in the query. E.g. some existing use cases which have been using invalid columns will face unexpected errors. I'd suggest adding a metric to capture those cases for now instead of directly throwing exception.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org