You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/19 08:12:41 UTC
[GitHub] [flink] zentol commented on a change in pull request #16879: [FLINK-23840][runtime] Improve confusing log / exception message when…
zentol commented on a change in pull request #16879:
URL: https://github.com/apache/flink/pull/16879#discussion_r691876343
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointStorageLoader.java
##########
@@ -187,27 +187,44 @@ public static CheckpointStorage load(
logger.info(
"Using legacy state backend {} as Job checkpoint storage",
rootStateBackend);
+ if (fromApplication != null) {
+ logger.warn(
+ "Checkpoint storage passed via StreamExecutionEnvironment is ignored because the legacy state backend '{}' is used instead.",
Review comment:
That's not _really_ an explanation for why the passed checkpoint storage is ignored.
If I read this I immediately wonder why the legacy state backend is used 🤷
The fact that legacy state backends take precedence would be a good hint, i.e., `[-...]because the legacy state backend '{}' is configured which takes precedence.`
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointStorageLoader.java
##########
@@ -187,27 +187,44 @@ public static CheckpointStorage load(
logger.info(
"Using legacy state backend {} as Job checkpoint storage",
rootStateBackend);
+ if (fromApplication != null) {
+ logger.warn(
+ "Checkpoint storage passed via StreamExecutionEnvironment is ignored because the legacy state backend '{}' is used instead.",
+ rootStateBackend.getClass());
+ }
+ if (config.get(CheckpointingOptions.CHECKPOINT_STORAGE) != null) {
+ logger.warn(
+ "Config option '{}' is ignored because the legacy state backend '{}' is used instead.",
Review comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org