You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2017/11/11 19:41:43 UTC
[GitHub] spark pull request #19724: [SPARK-22464][BACKPORT-2.2][SQL] No pushdown for ...
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/19724
[SPARK-22464][BACKPORT-2.2][SQL] No pushdown for Hive metastore partition predicates containing null-safe equality
## What changes were proposed in this pull request?
`<=>` is not supported by Hive metastore partition predicate pushdown. We should not push down it to Hive metastore when they are be using in partition predicates.
## How was this patch tested?
Added a test case
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gatorsmile/spark backportSPARK-22464
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19724.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19724
----
commit ec7e4b8105af4e6c3741dd9af27e24faa7ebb395
Author: gatorsmile <ga...@gmail.com>
Date: 2017-11-07T20:57:43Z
[SPARK-22464][SQL] No pushdown for Hive metastore partition predicates containing null-safe equality
## What changes were proposed in this pull request?
`<=>` is not supported by Hive metastore partition predicate pushdown. We should not push down it to Hive metastore when they are be using in partition predicates.
## How was this patch tested?
Added a test case
Author: gatorsmile <ga...@gmail.com>
Closes #19682 from gatorsmile/fixLimitPushDown.
# Conflicts:
# sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
# sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveClientSuite.scala
commit c629aaf4c98bb83b9b0d95e165abb85ed281ef9d
Author: gatorsmile <ga...@gmail.com>
Date: 2017-11-11T19:41:15Z
TEST
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19724: [SPARK-22464][BACKPORT-2.2][SQL] No pushdown for Hive me...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19724
**[Test build #83731 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83731/testReport)** for PR 19724 at commit [`c629aaf`](https://github.com/apache/spark/commit/c629aaf4c98bb83b9b0d95e165abb85ed281ef9d).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19724: [SPARK-22464][BACKPORT-2.2][SQL] No pushdown for Hive me...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19724
cc @cloud-fan
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19724: [SPARK-22464][BACKPORT-2.2][SQL] No pushdown for ...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile closed the pull request at:
https://github.com/apache/spark/pull/19724
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19724: [SPARK-22464][BACKPORT-2.2][SQL] No pushdown for Hive me...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19724
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19724: [SPARK-22464][BACKPORT-2.2][SQL] No pushdown for Hive me...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19724
**[Test build #83731 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83731/testReport)** for PR 19724 at commit [`c629aaf`](https://github.com/apache/spark/commit/c629aaf4c98bb83b9b0d95e165abb85ed281ef9d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19724: [SPARK-22464][BACKPORT-2.2][SQL] No pushdown for Hive me...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19724
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83731/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19724: [SPARK-22464][BACKPORT-2.2][SQL] No pushdown for Hive me...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19724
thanks, merging to 2.2!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org