You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shenyu.apache.org by "yangjj-iso (via GitHub)" <gi...@apache.org> on 2026/10/14 12:03:49 UTC
[PR] [ISSUE #7599] Receive the complete Apollo registry and data-sync integration [shenyu-plugin-store]
yangjj-iso opened a new pull request, #28:
URL: https://github.com/apache/shenyu-plugin-store/pull/28
Receive the complete Apollo integration for apache/shenyu#7599 in one `shenyu-extension-apollo` reactor: Admin listener, gateway data-sync, instance registry and sync starter. The companion one-release deprecation notice is https://github.com/apache/shenyu/pull/7627; the later main removal is a separate gated draft.
- Transfer all 31 original source/test/resource/POM files from core commit `971354fef10260e46e09ed951e0bff4d9b5e4040`, preserving runtime implementation, packages, `apollo` SPI key, configuration and stored-key behavior.
- Add Admin/gateway auto-configuration tests and a real `ShenyuInstanceRegisterRepositoryFactory.loadRepository("apollo")` test. Keep all original tests, including real Apollo `DefaultConfig` asynchronous interested-prefix filtering and registry instance updates.
- Own Apollo client/OpenAPI 2.1.0 dependency management in the extension. Shade middleware dependencies while explicitly excluding retained core APIs and the sibling sync module; retain published runtime dependencies. Add a CI check of final JAR implementation classes, SPI and Boot registration resources, and absence of embedded core/sibling classes.
- Add `docs/plugin-store-apollo.md`, enablement examples, preserved legacy config fragments, licenses and the staged publication/cutover/rollback contract. Keep `ApolloPathConstants` in core as a dependency-free compatibility shim rather than duplicate its class in the extension.
Validation:
- All seven receiving reactor modules passed `clean verify`: 30 tests, zero failures/errors/skips, Checkstyle and RAT. The final packaging check passed for all four JARs.
- Compatible core API preparation passed; the main deprecation branch passed all 209 modules at `validate`. The separate removal passed its 166-module affected `clean package` build and 29 targeted core/Admin/other-sync tests plus seven dependency-checker tests.
- New Maven/Python syntax and `git diff --check` passed.
The SDK integration fixture exercises the real Apollo client listener filtering with a controlled repository; it does not claim a live portal/config-service deployment. No artifact was published. Main removal must wait for dev-list consensus, a preceding released core deprecation cycle, receiving CI/staging validation, compatible single-owner artifact publication and an announced rollback window. The issue remains open until that coordinated release completes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7599] Receive the complete Apollo registry and data-sync integration [shenyu-plugin-store]
Posted by "yangjj-iso (via GitHub) via dev" <de...@shenyu.apache.org>.
yangjj-iso commented on PR #28:
URL: https://github.com/apache/shenyu-plugin-store/pull/28#issuecomment-6685100857
Updated validation request for current head f6bf1264e1fd6543d0e66fa9d0214a1d04c44a24: the Build run https://github.com/apache/shenyu-plugin-store/actions/runs/41361429919 remains action_required. Could a maintainer approve it so the current external Apollo stack, including the .list key handling and snapshot-compatible deletion tests, receives hosted CI validation?
The paired core PR apache/shenyu#7628 is now ready for code review, and its newly fixed Admin, HTTP-sync starter and Java 21 plugin tests have passed in the current CI run. Its IT workflow has also passed; remaining CI/E2E work is still running. Those core results do not replace this receiver's validation. The completed deprecation release, published compatible artifacts with unique ownership, deployment checks and rollback announcement remain required before the core removal can merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7599] Receive the complete Apollo registry and data-sync integration [shenyu-plugin-store]
Posted by "yangjj-iso (via GitHub)" <gi...@apache.org>.
yangjj-iso commented on PR #28:
URL: https://github.com/apache/shenyu-plugin-store/pull/28#issuecomment-6267009151
The receiving Build workflow is still awaiting maintainer approval. Could a maintainer please approve it so the Apollo extension can receive upstream CI validation? The contributor account receives 403 when requesting workflow approval.
The paired main removal #7628 has been synchronized and validated locally, but remains draft. This request does not waive the preceding deprecation release, publication/coordinate ownership or rollback requirements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org