You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2022/09/24 13:56:09 UTC
[commons-rng] branch master updated (b329c214 -> d150ee2f)
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git
from b329c214 spotbugs: Allow floating-point loop control in sampling example
new f7926801 Drop antrun 1.8 for 3.1.0 in commons parent
new 31600bca Drop surefire 3.0.0-M5 for 3.0.0-M7 in commons parent
new 1b9a1daa Drop junit 5.7.2 for 5.9.0 in commons parent
new 457a6e93 Drop checkstyle 3.1.2 for 3.2.0 in commons parent
new 94d602c6 Update revapi plugin
new 1238424c Update checkstyle config using latest example
new f9bcccdd Simplify boolean expression
new d150ee2f Correct line number for checkstyle suppression
The 8 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
commons-rng-examples/examples-stress/pom.xml | 1 -
commons-rng-examples/pom.xml | 1 -
.../commons/rng/sampling/ListSamplerTest.java | 4 +-
docs-archive/pom.xml | 1 -
pom.xml | 38 +---------------
.../checkstyle/checkstyle-suppressions.xml | 2 +-
src/main/resources/checkstyle/checkstyle.xml | 51 +++++++++++-----------
7 files changed, 31 insertions(+), 67 deletions(-)
[commons-rng] 07/08: Simplify boolean expression
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git
commit f9bcccdd5eb5649bc176214ef79a32f4eb13fb43
Author: Alex Herbert <ah...@apache.org>
AuthorDate: Sat Sep 24 14:45:00 2022 +0100
Simplify boolean expression
---
.../test/java/org/apache/commons/rng/sampling/ListSamplerTest.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/ListSamplerTest.java b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/ListSamplerTest.java
index 391ec83e..68e036ef 100644
--- a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/ListSamplerTest.java
+++ b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/ListSamplerTest.java
@@ -223,10 +223,10 @@ class ListSamplerTest {
boolean same) {
for (int i = start; i < end; i++) {
if (!orig.get(i).equals(list.get(i))) {
- return same ? false : true;
+ return !same;
}
}
- return same ? true : false;
+ return same;
}
private static <T extends Set<String>> int findSample(List<T> u,
[commons-rng] 05/08: Update revapi plugin
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git
commit 94d602c68758ae1741ad4ddfc306cee1200ce78f
Author: Alex Herbert <ah...@apache.org>
AuthorDate: Sat Sep 24 14:26:31 2022 +0100
Update revapi plugin
maven plugin 0.14.6 -> 0.14.7
java version 0.26.1 -> 0.27.0
---
pom.xml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pom.xml b/pom.xml
index 8c57a4f3..03a879a5 100644
--- a/pom.xml
+++ b/pom.xml
@@ -53,8 +53,8 @@
<commons.encoding>UTF-8</commons.encoding>
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
- <rng.revapi.version>0.14.6</rng.revapi.version>
- <rng.revapi.java.version>0.26.1</rng.revapi.java.version>
+ <rng.revapi.version>0.14.7</rng.revapi.version>
+ <rng.revapi.java.version>0.27.0</rng.revapi.java.version>
<rng.mathjax.url>https://cdn.jsdelivr.net/npm/mathjax@3/es5/tex-mml-chtml.js</rng.mathjax.url>
<!-- Workaround to avoid duplicating config files. -->
<rng.parent.dir>${basedir}</rng.parent.dir>
[commons-rng] 02/08: Drop surefire 3.0.0-M5 for 3.0.0-M7 in commons parent
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git
commit 31600bca084cc20eee11b0d86dce9172e84c42cf
Author: Alex Herbert <ah...@apache.org>
AuthorDate: Sat Sep 24 14:01:10 2022 +0100
Drop surefire 3.0.0-M5 for 3.0.0-M7 in commons parent
---
pom.xml | 2 --
1 file changed, 2 deletions(-)
diff --git a/pom.xml b/pom.xml
index 96ff0068..7ff1cef4 100644
--- a/pom.xml
+++ b/pom.xml
@@ -60,7 +60,6 @@
<rng.checkstyle.version>3.1.2</rng.checkstyle.version>
<rng.checkstyle.dep.version>8.45</rng.checkstyle.dep.version>
<rng.mathjax.url>https://cdn.jsdelivr.net/npm/mathjax@3/es5/tex-mml-chtml.js</rng.mathjax.url>
- <rng.surefire.version>3.0.0-M5</rng.surefire.version>
<rng.junit5.version>5.7.2</rng.junit5.version>
<!-- Workaround to avoid duplicating config files. -->
<rng.parent.dir>${basedir}</rng.parent.dir>
@@ -193,7 +192,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
- <version>${rng.surefire.version}</version>
<configuration>
<!-- Fix for OpenJDK 8 now validating class-path attributes in Jar manifests. -->
<!-- See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=912333#63 -->
[commons-rng] 04/08: Drop checkstyle 3.1.2 for 3.2.0 in commons parent
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git
commit 457a6e93221c5b545396d15214ee90648d768f87
Author: Alex Herbert <ah...@apache.org>
AuthorDate: Sat Sep 24 14:20:01 2022 +0100
Drop checkstyle 3.1.2 for 3.2.0 in commons parent
Update checkstyle dependency 8.45 for 9.3 in commons parent
---
commons-rng-examples/examples-stress/pom.xml | 1 -
commons-rng-examples/pom.xml | 1 -
docs-archive/pom.xml | 1 -
pom.xml | 27 ---------------------------
4 files changed, 30 deletions(-)
diff --git a/commons-rng-examples/examples-stress/pom.xml b/commons-rng-examples/examples-stress/pom.xml
index 82bbe772..8a839717 100644
--- a/commons-rng-examples/examples-stress/pom.xml
+++ b/commons-rng-examples/examples-stress/pom.xml
@@ -64,7 +64,6 @@
<plugins>
<plugin>
<artifactId>maven-checkstyle-plugin</artifactId>
- <version>${rng.checkstyle.version}</version>
<!-- The custom ApplicationException cannot be loaded by checkstyle unless the source is
compiled. Checkstyle runs in the validate phase so here we switch to verify -->
<executions>
diff --git a/commons-rng-examples/pom.xml b/commons-rng-examples/pom.xml
index 3d09c04a..ededd953 100644
--- a/commons-rng-examples/pom.xml
+++ b/commons-rng-examples/pom.xml
@@ -91,7 +91,6 @@
<plugins>
<plugin>
<artifactId>maven-pmd-plugin</artifactId>
- <version>${rng.pmd.version}</version>
<configuration>
<failOnViolation>false</failOnViolation>
</configuration>
diff --git a/docs-archive/pom.xml b/docs-archive/pom.xml
index 04508366..a8b20153 100644
--- a/docs-archive/pom.xml
+++ b/docs-archive/pom.xml
@@ -175,7 +175,6 @@
<plugin>
<artifactId>maven-pmd-plugin</artifactId>
- <version>${rng.pmd.version}</version>
<configuration>
<skip>true</skip>
</configuration>
diff --git a/pom.xml b/pom.xml
index dfc86c93..8c57a4f3 100644
--- a/pom.xml
+++ b/pom.xml
@@ -53,12 +53,8 @@
<commons.encoding>UTF-8</commons.encoding>
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
- <rng.pmd.version>3.14.0</rng.pmd.version>
- <rng.pmd.dep.version>6.37.0</rng.pmd.dep.version>
<rng.revapi.version>0.14.6</rng.revapi.version>
<rng.revapi.java.version>0.26.1</rng.revapi.java.version>
- <rng.checkstyle.version>3.1.2</rng.checkstyle.version>
- <rng.checkstyle.dep.version>8.45</rng.checkstyle.dep.version>
<rng.mathjax.url>https://cdn.jsdelivr.net/npm/mathjax@3/es5/tex-mml-chtml.js</rng.mathjax.url>
<!-- Workaround to avoid duplicating config files. -->
<rng.parent.dir>${basedir}</rng.parent.dir>
@@ -214,14 +210,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
- <version>${rng.checkstyle.version}</version>
- <dependencies>
- <dependency>
- <groupId>com.puppycrawl.tools</groupId>
- <artifactId>checkstyle</artifactId>
- <version>${rng.checkstyle.dep.version}</version>
- </dependency>
- </dependencies>
<configuration>
<includeTestSourceDirectory>true</includeTestSourceDirectory>
<configLocation>${rng.parent.dir}/src/main/resources/checkstyle/checkstyle.xml</configLocation>
@@ -262,19 +250,6 @@
</plugin>
<plugin>
<artifactId>maven-pmd-plugin</artifactId>
- <version>${rng.pmd.version}</version>
- <dependencies>
- <dependency>
- <groupId>net.sourceforge.pmd</groupId>
- <artifactId>pmd-core</artifactId>
- <version>${rng.pmd.dep.version}</version>
- </dependency>
- <dependency>
- <groupId>net.sourceforge.pmd</groupId>
- <artifactId>pmd-java</artifactId>
- <version>${rng.pmd.dep.version}</version>
- </dependency>
- </dependencies>
<configuration>
<targetJdk>${maven.compiler.target}</targetJdk>
<skipEmptyReport>false</skipEmptyReport>
@@ -430,7 +405,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
- <version>${rng.checkstyle.version}</version>
<configuration>
<configLocation>${rng.parent.dir}/src/main/resources/checkstyle/checkstyle.xml</configLocation>
<headerLocation>${rng.parent.dir}/src/main/resources/checkstyle/license-header.txt</headerLocation>
@@ -458,7 +432,6 @@
</plugin>
<plugin>
<artifactId>maven-pmd-plugin</artifactId>
- <version>${rng.pmd.version}</version>
<configuration>
<targetJdk>${maven.compiler.target}</targetJdk>
<skipEmptyReport>false</skipEmptyReport>
[commons-rng] 08/08: Correct line number for checkstyle suppression
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git
commit d150ee2f48d92a8baad7aeff0e4ac4cbd2df443e
Author: Alex Herbert <ah...@apache.org>
AuthorDate: Sat Sep 24 14:48:25 2022 +0100
Correct line number for checkstyle suppression
---
src/main/resources/checkstyle/checkstyle-suppressions.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/main/resources/checkstyle/checkstyle-suppressions.xml b/src/main/resources/checkstyle/checkstyle-suppressions.xml
index b3c71e1a..31865d56 100644
--- a/src/main/resources/checkstyle/checkstyle-suppressions.xml
+++ b/src/main/resources/checkstyle/checkstyle-suppressions.xml
@@ -23,7 +23,7 @@
<suppress checks="ParameterNumber" files="[\\/]LargeMeanPoissonSampler\.java$" />
<suppress checks="ParameterNumber" files="source64[\\/].*XoShiRo512.*\.java$" />
<suppress checks="ParameterNumber" files="source64[\\/]L128X256Mix\.java$" />
- <suppress checks="UnnecessaryParentheses" files=".*stress[/\\]StressTestCommand\.java$" lines="672" />
+ <suppress checks="UnnecessaryParentheses" files=".*stress[/\\]StressTestCommand\.java$" lines="696" />
<!-- Special to allow withUniformRandomProvider to act as a constructor. -->
<suppress checks="HiddenField" files=".*Sampler\.java$" message="'rng' hides a field." />
<!-- Methods have the names from the Spliterator interface that is implemented by child classes.
[commons-rng] 06/08: Update checkstyle config using latest example
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git
commit 1238424c9d65eaa435fbf86c7920245b2876e84e
Author: Alex Herbert <ah...@apache.org>
AuthorDate: Sat Sep 24 14:42:10 2022 +0100
Update checkstyle config using latest example
Updated from:
https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/sun_checks.xml
---
src/main/resources/checkstyle/checkstyle.xml | 51 ++++++++++++++--------------
1 file changed, 26 insertions(+), 25 deletions(-)
diff --git a/src/main/resources/checkstyle/checkstyle.xml b/src/main/resources/checkstyle/checkstyle.xml
index b3bf596b..51b420ae 100644
--- a/src/main/resources/checkstyle/checkstyle.xml
+++ b/src/main/resources/checkstyle/checkstyle.xml
@@ -26,6 +26,15 @@
https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/sun_checks.xml
-->
<module name="Checker">
+ <property name="fileExtensions" value="java, properties, xml" />
+
+ <!-- Excludes all 'module-info.java' files -->
+ <!-- See https://checkstyle.org/config_filefilters.html -->
+ <module name="BeforeExecutionExclusionFileFilter">
+ <property name="fileNamePattern" value="module\-info\.java$"/>
+ </module>
+
+ <!-- https://checkstyle.org/config_filters.html#SuppressionFilter -->
<module name="SuppressionFilter">
<!-- Default property set by maven-checkstyle-plugin -->
<property name="file" value="${checkstyle.suppressions.file}"/>
@@ -34,28 +43,20 @@
<property name="localeLanguage" value="en"/>
- <property name="fileExtensions" value="java, properties, xml" />
-
- <!-- Excludes all 'module-info.java' files -->
- <!-- See https://checkstyle.org/config_filefilters.html -->
- <module name="BeforeExecutionExclusionFileFilter">
- <property name="fileNamePattern" value="module\-info\.java$" />
- </module>
-
<!-- Checks that a package-info.java file exists for each package. -->
- <!-- See http://checkstyle.sourceforge.net/config_javadoc.html#JavadocPackage -->
+ <!-- See https://checkstyle.org/config_javadoc.html#JavadocPackage -->
<module name="JavadocPackage" />
<!-- Checks whether files end with a new line. -->
- <!-- See http://checkstyle.sourceforge.net/config_misc.html#NewlineAtEndOfFile -->
+ <!-- See https://checkstyle.org/config_misc.html#NewlineAtEndOfFile -->
<module name="NewlineAtEndOfFile" />
<!-- Checks that property files contain the same keys. -->
- <!-- See http://checkstyle.sourceforge.net/config_misc.html#Translation -->
+ <!-- See https://checkstyle.org/config_misc.html#Translation -->
<module name="Translation" />
<!-- Checks for Size Violations. -->
- <!-- See http://checkstyle.sourceforge.net/config_sizes.html -->
+ <!-- See https://checkstyle.org/config_sizes.html -->
<module name="FileLength" />
<module name="LineLength">
<property name="fileExtensions" value="java"/>
@@ -65,11 +66,11 @@
</module>
<!-- Checks for whitespace -->
- <!-- See http://checkstyle.sourceforge.net/config_whitespace.html -->
+ <!-- See http://checkstyle.org/config_whitespace.html -->
<module name="FileTabCharacter" />
<!-- Miscellaneous other checks. -->
- <!-- See http://checkstyle.sourceforge.net/config_misc.html -->
+ <!-- See http://checkstyle.org/config_misc.html -->
<module name="RegexpSingleline">
<property name="format" value="\s+$" />
<property name="minimum" value="0" />
@@ -78,7 +79,7 @@
</module>
<!-- Checks for Headers -->
- <!-- See http://checkstyle.sourceforge.net/config_header.html -->
+ <!-- See http://checkstyle.org/config_header.html -->
<module name="Header">
<property name="headerFile" value="${checkstyle.header.file}"/>
</module>
@@ -86,7 +87,7 @@
<module name="TreeWalker">
<!-- Checks for Javadoc comments. -->
- <!-- See http://checkstyle.sourceforge.net/config_javadoc.html -->
+ <!-- See http://checkstyle.org/config_javadoc.html -->
<module name="InvalidJavadocPosition"/>
<module name="JavadocMethod" />
<module name="JavadocType" />
@@ -101,7 +102,7 @@
</module>
<!-- Checks for Naming Conventions. -->
- <!-- See http://checkstyle.sourceforge.net/config_naming.html -->
+ <!-- See http://checkstyle.org/config_naming.html -->
<module name="ConstantName" />
<module name="LocalFinalVariableName" />
<module name="LocalVariableName" />
@@ -113,7 +114,7 @@
<module name="TypeName" />
<!-- Checks for imports -->
- <!-- See http://checkstyle.sourceforge.net/config_import.html -->
+ <!-- See http://checkstyle.org/config_import.html -->
<module name="AvoidStarImport" />
<module name="IllegalImport" /> <!-- defaults to sun.* packages -->
<module name="RedundantImport" />
@@ -122,12 +123,12 @@
</module>
<!-- Checks for Size Violations. -->
- <!-- See http://checkstyle.sourceforge.net/config_sizes.html -->
+ <!-- See http://checkstyle.org/config_sizes.html -->
<module name="MethodLength" />
<module name="ParameterNumber" />
<!-- Checks for whitespace -->
- <!-- See http://checkstyle.sourceforge.net/config_whitespace.html -->
+ <!-- See http://checkstyle.org/config_whitespace.html -->
<module name="EmptyForIteratorPad" />
<module name="GenericWhitespace" />
<module name="MethodParamPad" />
@@ -148,12 +149,12 @@
</module>
<!-- Modifier Checks -->
- <!-- See http://checkstyle.sourceforge.net/config_modifiers.html -->
+ <!-- See http://checkstyle.org/config_modifiers.html -->
<module name="ModifierOrder" />
<module name="RedundantModifier" />
<!-- Checks for blocks. You know, those {}'s -->
- <!-- See http://checkstyle.sourceforge.net/config_blocks.html -->
+ <!-- See http://checkstyle.org/config_blocks.html -->
<module name="AvoidNestedBlocks" />
<module name="EmptyBlock" />
<module name="LeftCurly" />
@@ -161,7 +162,7 @@
<module name="RightCurly" />
<!-- Checks for common coding problems -->
- <!-- See http://checkstyle.sourceforge.net/config_coding.html -->
+ <!-- See http://checkstyle.org/config_coding.html -->
<module name="EmptyStatement" />
<module name="EqualsHashCode" />
<!-- Method parameters and local variables should not hide fields, except in constructors and setters -->
@@ -182,7 +183,7 @@
<module name="SimplifyBooleanReturn" />
<!-- Checks for class design -->
- <!-- See http://checkstyle.sourceforge.net/config_design.html -->
+ <!-- See http://checkstyle.org/config_design.html -->
<module name="DesignForExtension" />
<module name="FinalClass" />
<module name="HideUtilityClassConstructor" />
@@ -193,7 +194,7 @@
</module>
<!-- Miscellaneous other checks. -->
- <!-- See http://checkstyle.sourceforge.net/config_misc.html -->
+ <!-- See http://checkstyle.org/config_misc.html -->
<module name="ArrayTypeStyle" />
<!-- <module name="FinalParameters" /> -->
<module name="TodoComment">
[commons-rng] 01/08: Drop antrun 1.8 for 3.1.0 in commons parent
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git
commit f79268011a3ebb133320f643cfb05e92842068f1
Author: Alex Herbert <ah...@apache.org>
AuthorDate: Sat Sep 24 13:59:46 2022 +0100
Drop antrun 1.8 for 3.1.0 in commons parent
---
pom.xml | 3 ---
1 file changed, 3 deletions(-)
diff --git a/pom.xml b/pom.xml
index 6af9e2de..96ff0068 100644
--- a/pom.xml
+++ b/pom.xml
@@ -60,7 +60,6 @@
<rng.checkstyle.version>3.1.2</rng.checkstyle.version>
<rng.checkstyle.dep.version>8.45</rng.checkstyle.dep.version>
<rng.mathjax.url>https://cdn.jsdelivr.net/npm/mathjax@3/es5/tex-mml-chtml.js</rng.mathjax.url>
- <rng.antrun.version>1.8</rng.antrun.version>
<rng.surefire.version>3.0.0-M5</rng.surefire.version>
<rng.junit5.version>5.7.2</rng.junit5.version>
<!-- Workaround to avoid duplicating config files. -->
@@ -590,7 +589,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-antrun-plugin</artifactId>
- <version>${rng.antrun.version}</version>
<executions>
<!-- For multi-module builds, only the parent directory requires a site checkout.
This task will create an empty directory as the site checkout is missing. -->
@@ -649,7 +647,6 @@ This is avoided by creating an empty directory when svn is not available.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-antrun-plugin</artifactId>
- <version>${rng.antrun.version}</version>
<executions>
<execution>
<id>remove-checkout</id>
[commons-rng] 03/08: Drop junit 5.7.2 for 5.9.0 in commons parent
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git
commit 1b9a1daae8d609c6eb6d45af7284bb28879965d5
Author: Alex Herbert <ah...@apache.org>
AuthorDate: Sat Sep 24 14:03:33 2022 +0100
Drop junit 5.7.2 for 5.9.0 in commons parent
---
pom.xml | 2 --
1 file changed, 2 deletions(-)
diff --git a/pom.xml b/pom.xml
index 7ff1cef4..dfc86c93 100644
--- a/pom.xml
+++ b/pom.xml
@@ -60,7 +60,6 @@
<rng.checkstyle.version>3.1.2</rng.checkstyle.version>
<rng.checkstyle.dep.version>8.45</rng.checkstyle.dep.version>
<rng.mathjax.url>https://cdn.jsdelivr.net/npm/mathjax@3/es5/tex-mml-chtml.js</rng.mathjax.url>
- <rng.junit5.version>5.7.2</rng.junit5.version>
<!-- Workaround to avoid duplicating config files. -->
<rng.parent.dir>${basedir}</rng.parent.dir>
<!-- Multi-module support fixed in commons-parent 55 -->
@@ -137,7 +136,6 @@
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter</artifactId>
- <version>${rng.junit5.version}</version>
<scope>test</scope>
</dependency>
</dependencies>