You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/05/13 03:45:40 UTC

[GitHub] [rocketmq] caigy commented on a diff in pull request #4295: [ISSUE #4287]add detail descriptions to readme

caigy commented on code in PR #4295:
URL: https://github.com/apache/rocketmq/pull/4295#discussion_r871976119


##########
broker/src/main/java/org/apache/rocketmq/broker/plugin/MessageStoreFactory.java:
##########
@@ -22,7 +22,7 @@
 import org.apache.rocketmq.store.MessageStore;
 
 public final class MessageStoreFactory {
-    public final static MessageStore build(MessageStorePluginContext context, MessageStore messageStore)
+    public static MessageStore build(MessageStorePluginContext context, MessageStore messageStore)

Review Comment:
   It seems this change has nothing to do with the issue, you may open another issue to change it.



##########
README.md:
##########
@@ -41,8 +41,8 @@ It offers a variety of features:
 * [RocketMQ Client Go](https://github.com/apache/rocketmq-client-go)
 * [RocketMQ Client Python](https://github.com/apache/rocketmq-client-python)
 * [RocketMQ Client Nodejs](https://github.com/apache/rocketmq-client-nodejs)
-* [RocketMQ Spring](https://github.com/apache/rocketmq-spring)
-* [RocketMQ Exporter](https://github.com/apache/rocketmq-exporter)
+* [RocketMQ Spring](https://github.com/apache/rocketmq-spring): The integration component of RocketMQ and spring framework

Review Comment:
   1. 'spring' should be 'Spring'. 
   2. Accurately rocketmq-spring is starter of Spring Boot, not integration to Spring Framework itself.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org