You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Sriram Rao (JIRA)" <ji...@apache.org> on 2008/05/17 01:17:55 UTC

[jira] Created: (HADOOP-3410) KFS implementation needs to return file modification time

KFS implementation needs to return file modification time
---------------------------------------------------------

                 Key: HADOOP-3410
                 URL: https://issues.apache.org/jira/browse/HADOOP-3410
             Project: Hadoop Core
          Issue Type: Bug
    Affects Versions: 0.15.3
            Reporter: Sriram Rao
            Priority: Minor


The KFS glue code in fs/kfs currently returns 0 for file modification time.  This needs to be fixed to return the correct value.  I will provide a patch:
 - jar file for kfs-0.1.3.jar; this should replace lib/kfs-0.1.jar
 - patch with the fix

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3410) KFS implementation needs to return file modification time

Posted by "Sriram Rao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sriram Rao updated HADOOP-3410:
-------------------------------

    Attachment: kfs-0.1.3.jar
                patch.3410

There are two attachements for this issue:
 - patch: that fixes the code in fs/kfs
 -  kfs-0.1.3.jar file.  This should replace lib/kfs-0.1.jar

> KFS implementation needs to return file modification time
> ---------------------------------------------------------
>
>                 Key: HADOOP-3410
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3410
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.15.3
>            Reporter: Sriram Rao
>            Priority: Minor
>         Attachments: kfs-0.1.3.jar, patch.3410
>
>
> The KFS glue code in fs/kfs currently returns 0 for file modification time.  This needs to be fixed to return the correct value.  I will provide a patch:
>  - jar file for kfs-0.1.3.jar; this should replace lib/kfs-0.1.jar
>  - patch with the fix

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3410) KFS implementation needs to return file modification time

Posted by "Sriram Rao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598117#action_12598117 ] 

Sriram Rao commented on HADOOP-3410:
------------------------------------

The existing test cases that are included for KFS cover this interface.  The change here is adding a call to the KFS library to get at the file's modification time; previously, kfs-0.1.jar didn't include such an API and hence I was returning 0.

> KFS implementation needs to return file modification time
> ---------------------------------------------------------
>
>                 Key: HADOOP-3410
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3410
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.15.3
>            Reporter: Sriram Rao
>            Assignee: Sriram Rao
>            Priority: Minor
>             Fix For: 0.18.0
>
>         Attachments: kfs-0.1.3.jar, patch.3410
>
>
> The KFS glue code in fs/kfs currently returns 0 for file modification time.  This needs to be fixed to return the correct value.  I will provide a patch:
>  - jar file for kfs-0.1.3.jar; this should replace lib/kfs-0.1.jar
>  - patch with the fix

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3410) KFS implementation needs to return file modification time

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-3410:
----------------------------------

    Fix Version/s: 0.18.0
         Assignee: Sriram Rao
           Status: Open  (was: Patch Available)

Could you add a test case for this?

> KFS implementation needs to return file modification time
> ---------------------------------------------------------
>
>                 Key: HADOOP-3410
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3410
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.15.3
>            Reporter: Sriram Rao
>            Assignee: Sriram Rao
>            Priority: Minor
>             Fix For: 0.18.0
>
>         Attachments: kfs-0.1.3.jar, patch.3410
>
>
> The KFS glue code in fs/kfs currently returns 0 for file modification time.  This needs to be fixed to return the correct value.  I will provide a patch:
>  - jar file for kfs-0.1.3.jar; this should replace lib/kfs-0.1.jar
>  - patch with the fix

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3410) KFS implementation needs to return file modification time

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601923#action_12601923 ] 

Hudson commented on HADOOP-3410:
--------------------------------

Integrated in Hadoop-trunk #511 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/511/])

> KFS implementation needs to return file modification time
> ---------------------------------------------------------
>
>                 Key: HADOOP-3410
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3410
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.15.3
>            Reporter: Sriram Rao
>            Assignee: Sriram Rao
>            Priority: Minor
>             Fix For: 0.18.0
>
>         Attachments: kfs-0.1.3.jar, patch.3410
>
>
> The KFS glue code in fs/kfs currently returns 0 for file modification time.  This needs to be fixed to return the correct value.  I will provide a patch:
>  - jar file for kfs-0.1.3.jar; this should replace lib/kfs-0.1.jar
>  - patch with the fix

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HADOOP-3410) KFS implementation needs to return file modification time

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting resolved HADOOP-3410.
----------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]

I just committed this.  Thanks, Sriram!

> KFS implementation needs to return file modification time
> ---------------------------------------------------------
>
>                 Key: HADOOP-3410
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3410
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.15.3
>            Reporter: Sriram Rao
>            Assignee: Sriram Rao
>            Priority: Minor
>             Fix For: 0.18.0
>
>         Attachments: kfs-0.1.3.jar, patch.3410
>
>
> The KFS glue code in fs/kfs currently returns 0 for file modification time.  This needs to be fixed to return the correct value.  I will provide a patch:
>  - jar file for kfs-0.1.3.jar; this should replace lib/kfs-0.1.jar
>  - patch with the fix

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3410) KFS implementation needs to return file modification time

Posted by "Sriram Rao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sriram Rao updated HADOOP-3410:
-------------------------------

    Status: Patch Available  (was: Open)

I have submitted patches for this issue (as attachments to this bug).  

> KFS implementation needs to return file modification time
> ---------------------------------------------------------
>
>                 Key: HADOOP-3410
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3410
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.15.3
>            Reporter: Sriram Rao
>            Priority: Minor
>         Attachments: kfs-0.1.3.jar, patch.3410
>
>
> The KFS glue code in fs/kfs currently returns 0 for file modification time.  This needs to be fixed to return the correct value.  I will provide a patch:
>  - jar file for kfs-0.1.3.jar; this should replace lib/kfs-0.1.jar
>  - patch with the fix

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3410) KFS implementation needs to return file modification time

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597691#action_12597691 ] 

Hadoop QA commented on HADOOP-3410:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12382229/kfs-0.1.3.jar
  against trunk revision 656939.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2495/console

This message is automatically generated.

> KFS implementation needs to return file modification time
> ---------------------------------------------------------
>
>                 Key: HADOOP-3410
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3410
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.15.3
>            Reporter: Sriram Rao
>            Priority: Minor
>         Attachments: kfs-0.1.3.jar, patch.3410
>
>
> The KFS glue code in fs/kfs currently returns 0 for file modification time.  This needs to be fixed to return the correct value.  I will provide a patch:
>  - jar file for kfs-0.1.3.jar; this should replace lib/kfs-0.1.jar
>  - patch with the fix

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.