[jira] [Commented] (HBASE-16870) Add the metrics of replication sources which were transformed from other died rs to ReplicationLoad

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-16870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15586615#comment-15586615 ] 

Ted Yu commented on HBASE-16870:
--------------------------------

Is it possible to add test in TestReplicationSmallTests ?

> Add the metrics of replication sources which were transformed from other died rs to ReplicationLoad
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-16870
>                 URL: https://issues.apache.org/jira/browse/HBASE-16870
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>            Priority: Minor
>         Attachments: HBASE-16870.patch
>
>
> {code}
>   private void buildReplicationLoad() {
>     // get source
>     List<ReplicationSourceInterface> sources = this.replicationManager.getSources();
>     List<MetricsSource> sourceMetricsList = new ArrayList<MetricsSource>();
>     for (ReplicationSourceInterface source : sources) {
>       if (source instanceof ReplicationSource) {
>         sourceMetricsList.add(((ReplicationSource) source).getSourceMetrics());
>       }
>     }
>     // get sink
>     MetricsSink sinkMetrics = this.replicationSink.getSinkMetrics();
>     this.replicationLoad.buildReplicationLoad(sourceMetricsList, sinkMetrics);
>   }
> {code}
> The buildReplicationLoad method in o.a.h.h.r.r.Replication didn't consider the replication source which were transformed from other died rs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)