You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/28 03:50:21 UTC

[GitHub] [pulsar-client-cpp] shibd opened a new issue, #93: [feature request] C++ and Python client support consumer memory limits.

shibd opened a new issue, #93:
URL: https://github.com/apache/pulsar-client-cpp/issues/93

   ### Search before asking
   
   - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
   
   
   ### Motivation
   
   [PIP-74](https://github.com/apache/pulsar/wiki/PIP-74%3A-Pulsar-client-memory-limits)
   
   C++ client consumers have not implemented memory limits yet. 
   
   
   ### Solution
   
   There are several key points to achieving this feature.
   1. Reconstructing the consumer structure.
      - https://github.com/apache/pulsar/pull/16969
      - Abstract `ConsumerBase`, put together some common logic.
   2. Refactoring single-consumer and MultiTopicConsumer transports type.
      - In the current implementation of C++, messages are sent to multi-topic consumers by blocking queue + listener, which is an old historical implementation. If you want to achieve memory limits, you need to do the same as the current java implementation, let `MuiltiTopicConsumer` take the initiative to control the message.
   
   
   ### Alternatives
   
   Here's an imperfect draft: https://github.com/apache/pulsar/pull/16933
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [x] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org