You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/08/05 15:49:13 UTC

[GitHub] [hudi] Mathieu1124 commented on a change in pull request #1920: [HUDI-1150]Fix unable to parse input partition field :1 exception whe…

Mathieu1124 commented on a change in pull request #1920:
URL: https://github.com/apache/hudi/pull/1920#discussion_r465826269



##########
File path: hudi-spark/src/main/java/org/apache/hudi/keygen/parser/HoodieDateTimeParserImpl.java
##########
@@ -58,7 +58,7 @@ public HoodieDateTimeParserImpl(TypedProperties config) {
     }
   }
 
-  private String getConfigInputDateFormatDelimiter() {
+  public String getConfigInputDateFormatDelimiter() {

Review comment:
       > can we make this package-private?
   
   @pratyakshsharma thanks for your review.
   I tried protected, it's not enough.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org