You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/06/09 08:39:36 UTC
[GitHub] [james-project] chibenwa opened a new pull request #487: [WIP] JAMES-3596 Collocate all server applications in server/apps folder
chibenwa opened a new pull request #487:
URL: https://github.com/apache/james-project/pull/487
TODO :
- [x] cassandra-app +cassandra-app-ldap-tests
- [ ] distributed-app + distributed-app-ldap-tests
- [ ] memory-app (requires guice module extraction)
- [ ] jpa-app (requires guice module extraction)
- [ ] jpa-smtp-app
- [ ] spring-app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on a change in pull request #487: JAMES-3596 Collocate all server applications in server/apps folder
Posted by GitBox <gi...@apache.org>.
Arsnael commented on a change in pull request #487:
URL: https://github.com/apache/james-project/pull/487#discussion_r649668840
##########
File path: server/apps/cassandra-app-ldap-tests/pom.xml
##########
@@ -23,21 +23,33 @@
<parent>
<groupId>org.apache.james</groupId>
- <artifactId>james-server-guice</artifactId>
+ <artifactId>james-server</artifactId>
<version>3.7.0-SNAPSHOT</version>
- <relativePath>../pom.xml</relativePath>
+ <relativePath>../../pom.xml</relativePath>
</parent>
- <artifactId>james-server-cassandra-ldap-guice</artifactId>
+ <artifactId>james-server-cassandra-app-ldap-tessts</artifactId>
Review comment:
```suggestion
<artifactId>james-server-cassandra-app-ldap-tests</artifactId>
```
##########
File path: core/src/test/java/org/apache/james/core/UsernameTest.java
##########
@@ -148,9 +149,9 @@ void fromUsernameShouldThrowWhenTooLong() {
}
@Test
- void fromUsernameShouldThrowWhenMultipleDomainDelimiter() {
- assertThatThrownBy(() -> Username.of("aa@aa@aa"))
- .isInstanceOf(IllegalArgumentException.class);
+ void arbitraryCharInLocalPart() {
+ assertThatCode(() -> Username.of("Whatever_I- want3$$$###_! as lons I do not give a domain"))
+ .doesNotThrowAnyException();
Review comment:
Why do you change a test for Username in this commit/PR? Mix up with something else maybe?
##########
File path: server/container/guice/mailbox-jpa/pom.xml
##########
@@ -0,0 +1,85 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.james</groupId>
+ <artifactId>james-server-guice</artifactId>
+ <version>3.7.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+ <artifactId>james-server-guice-mailbox-jpa</artifactId>
+ <packaging>jar</packaging>
+
+ <name>Apache James :: Server :: JPA - guice injection</name>
+ <description>An advanced email server - JPA backend with guice injection</description>
+
+ <properties>
+ <jpa.includes>empty</jpa.includes>
Review comment:
What is this for?
##########
File path: server/apps/cassandra-app-ldap-tests/pom.xml
##########
@@ -23,21 +23,33 @@
<parent>
<groupId>org.apache.james</groupId>
- <artifactId>james-server-guice</artifactId>
+ <artifactId>james-server</artifactId>
<version>3.7.0-SNAPSHOT</version>
- <relativePath>../pom.xml</relativePath>
+ <relativePath>../../pom.xml</relativePath>
</parent>
- <artifactId>james-server-cassandra-ldap-guice</artifactId>
+ <artifactId>james-server-cassandra-app-ldap-tessts</artifactId>
Review comment:
Solved in a later commit, don't bother!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #487: JAMES-3596 Collocate all server applications in server/apps folder
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #487:
URL: https://github.com/apache/james-project/pull/487#discussion_r649680787
##########
File path: core/src/test/java/org/apache/james/core/UsernameTest.java
##########
@@ -148,9 +149,9 @@ void fromUsernameShouldThrowWhenTooLong() {
}
@Test
- void fromUsernameShouldThrowWhenMultipleDomainDelimiter() {
- assertThatThrownBy(() -> Username.of("aa@aa@aa"))
- .isInstanceOf(IllegalArgumentException.class);
+ void arbitraryCharInLocalPart() {
+ assertThatCode(() -> Username.of("Whatever_I- want3$$$###_! as lons I do not give a domain"))
+ .doesNotThrowAnyException();
Review comment:
Sorry mistake I likely wrote some tests to answer a ML thread while running long compilations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #487: JAMES-3596 Collocate all server applications in server/apps folder
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #487:
URL: https://github.com/apache/james-project/pull/487#issuecomment-859081682
I did a superficial review since the PR is huge and PRs consisting mainly of file moves are hard to read :)
( I am currenty in the eye of the cyclone the package has arrived but won't reach home before saturday)
The new organization looks fine to me.
The only thing that got me surprised was the choice to split
- cassandra-app-ldap-tests
- cli-integration-tests
- distributed-ldap-tests
Away from their respective modules (if I understand this change correctly). It puts testing modules in the apps/assembly directory which I find counter intuitive even if they are clearly marked as being tests.
Can you explain the rationale behind the split ? I'm not opposed but I would like to understand the why as it breaks expectations, and maybe ask that the why be explained in a readme in the apps dir so that people proposing new assemblies or manipulating assemblies would know if they need to provide a test module too.
Appart from that I'm all for it once the CI clears
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #487: JAMES-3596 Collocate all server applications in server/apps folder
Posted by GitBox <gi...@apache.org>.
Arsnael commented on pull request #487:
URL: https://github.com/apache/james-project/pull/487#issuecomment-859497544
```
10:51:21,756 [ERROR] The project org.apache.james:james-server-guice-jmx:3.7.0-SNAPSHOT (/home/jenkins/workspace/james_ApacheJames_PR-487/server/container/guice/jmx/pom.xml) has 1 error
10:51:21,757 [ERROR] 'dependencies.dependency.version' for org.apache.james:james-server-mailetcontainer-camel:jar is missing. @ line 67, column 21
10:51:21,758 [ERROR]
10:51:21,758 [ERROR] The project org.apache.james:james-server-guice-mailet:3.7.0-SNAPSHOT (/home/jenkins/workspace/james_ApacheJames_PR-487/server/container/guice/mailet/pom.xml) has 2 errors
10:51:21,759 [ERROR] 'dependencies.dependency.version' for org.apache.james:james-server-mailetcontainer-camel:jar is missing. @ line 70, column 21
10:51:21,760 [ERROR] 'dependencies.dependency.version' for org.apache.camel:camel-support:jar is missing. @ line 87, column 21
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #487: JAMES-3596 Collocate all server applications in server/apps folder
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #487:
URL: https://github.com/apache/james-project/pull/487#issuecomment-859193441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #487: JAMES-3596 Collocate all server applications in server/apps folder
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #487:
URL: https://github.com/apache/james-project/pull/487#issuecomment-858718839
Cc @Arsnael if you could have a look at it...
Cc @jeantil I don't know if you will get the time (wish you the best!) but as you were involved on the ML discussions...
If people do not mind I would like to merge this timely as the scene is now well setted up for some magestic git conflicts drama...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa edited a comment on pull request #487: JAMES-3596 Collocate all server applications in server/apps folder
Posted by GitBox <gi...@apache.org>.
chibenwa edited a comment on pull request #487:
URL: https://github.com/apache/james-project/pull/487#issuecomment-858707713
The result is easier to review on the main branch than as a PR...
https://github.com/chibenwa/james-project/tree/JAMES-3596/server/apps
- [x] Apps contains all servers applications: Spring server, Guice servers, CLIs, and their directly related tests
- [x] Guice servers apps do not contain guice modules. Project that required to be split were split
- [x] Fixed dead links
- [x] Renames artifactIds of server/apps to include app in them and not guice
- [x] Adapted depedencies everywhere needed
- [x] Apapted ZIP packagings to artifactId changs
- [x] Adapted READMEs on manual launch to include artifact id changes (guice)
I found that recent changes (before this PR) broke:
- JenkinsFile for stress tests
- dockerfiles for packaging
I discuss their removal in this mailing list thread: https://www.mail-archive.com/server-dev@james.apache.org/msg70419.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #487: JAMES-3596 Collocate all server applications in server/apps folder
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #487:
URL: https://github.com/apache/james-project/pull/487#issuecomment-858707713
The result is easier to review on the main branch than as a PR...
https://github.com/chibenwa/james-project/tree/JAMES-3596/server/apps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #487: JAMES-3596 Collocate all server applications in server/apps folder
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #487:
URL: https://github.com/apache/james-project/pull/487#issuecomment-859987803
https://github.com/apache/james-project/pull/492 removes the LDAP modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #487: JAMES-3596 Collocate all server applications in server/apps folder
Posted by GitBox <gi...@apache.org>.
chibenwa merged pull request #487:
URL: https://github.com/apache/james-project/pull/487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org