You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/30 02:42:46 UTC

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1395: fix(be): Modify the upstream to use the new JSON patch package

nic-chen commented on a change in pull request #1395:
URL: https://github.com/apache/apisix-dashboard/pull/1395#discussion_r567184831



##########
File path: api/internal/handler/upstream/upstream.go
##########
@@ -17,11 +17,11 @@
 package upstream
 
 import (
+	"encoding/json"
 	"net/http"
 	"reflect"
 	"strings"
 
-	"github.com/api7/go-jsonpatch"

Review comment:
       seems we don't need `go-jsonpatch` any more. try `go mod tidy` to see if we could remove it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org