You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by Eric Gonzalez <va...@users.sf.net> on 2014/07/30 19:46:48 UTC

[allura:tickets] #7604 Update with_ads decorator to catch AttributeError when accessing object get method



---

** [tickets:#7604] Update with_ads decorator to catch AttributeError when accessing object get method**

**Status:** open
**Milestone:** dir-backlog
**Created:** Wed Jul 30, 2014 05:46 PM UTC by Eric Gonzalez
**Last Updated:** Wed Jul 30, 2014 05:46 PM UTC
**Owner:** Eric Gonzalez

**As a SF user, when I try to access an editorial review for a project that does not have one, it should not throw a 500, it should redirect me to a 404.**

>Currently, if the item has a decorator: with_ads(), this method calls on the output object get(), however, the HTTPNotFound object does not provide this error. This action causes an AttributeError to be raised. Since we are not catching this error within the decorator, the page returns a 500.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #7604 Update with_ads decorator to catch AttributeError when accessing object get method

Posted by Eric Gonzalez <va...@users.sf.net>.
- **assigned_to**: Eric Gonzalez -->  nobody 



---

** [tickets:#7604] Update with_ads decorator to catch AttributeError when accessing object get method**

**Status:** open
**Milestone:** dir-backlog
**Created:** Wed Jul 30, 2014 05:46 PM UTC by Eric Gonzalez
**Last Updated:** Wed Jul 30, 2014 05:46 PM UTC
**Owner:** nobody

**As a SF user, when I try to access an editorial review for a project that does not have one, it should not throw a 500, it should redirect me to a 404.**

>Currently, if the item has a decorator: with_ads(), this method calls on the output object get(), however, the HTTPNotFound object does not provide this error. This action causes an AttributeError to be raised. Since we are not catching this error within the decorator, the page returns a 500.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.