[GitHub] nifi-minifi-cpp issue #73: MINIFI-254: Incremental update for linter changes

[apiri <gi...@git.apache.org>]

Github user apiri commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/73
  
    This is pretty fantastic and all the changes look good.  Built and ran a simple flow.
    
    Would you mind if I switched around the order of linter and testing in the travis file?
    
    From:
    `mkdir ./build && cd ./build && cmake .. && make && make linter && ./tests`
    to
    `mkdir ./build && cd ./build && cmake .. && make && ./tests  && make linter`
    
    The primary motivation is that in the review process being able to catch the test defects is nice and then if there are minor linting issues, it may or may not require follow up.  In the current scenario, a single linter issue will prevent tests from executing.
    
    Regardless, thanks for cleaning all this up and letting us automate the process using CI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---