You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "dpogue (via GitHub)" <gi...@apache.org> on 2023/04/09 03:03:40 UTC
[GitHub] [cordova-ios] dpogue opened a new pull request, #1302: Fix URL parsing for ATS in node 18
dpogue opened a new pull request, #1302:
URL: https://github.com/apache/cordova-ios/pull/1302
### Platforms affected
iOS, with node18
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Fixes #1290: currently parsing of `access`, `allow-navigation`, and `allow-intent` directives in config.xml for Application Transport Security is broken when using node 18 due to changes to how node handles URLs.
### Description
<!-- Describe your changes in detail -->
Move URL parsing to the (non-deprecated) WHATWG URL API in node, and workaround the issues that cause URL parsing to fail or return unexpected results with that API.
### Testing
<!-- Please describe in detail how you tested your changes. -->
All unit tests pass, but I would feel more confident if people tried throwing some weirder corner cases at this to ensure it's actually behaving consistently with previous versions.
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-commenter commented on pull request #1302: Fix URL parsing for ATS in node 18
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1302:
URL: https://github.com/apache/cordova-ios/pull/1302#issuecomment-1501028277
## [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1302?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1302](https://codecov.io/gh/apache/cordova-ios/pull/1302?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1e2ea8) into [master](https://codecov.io/gh/apache/cordova-ios/commit/e1e21cfafcfe7c0162b976627a8c1f1d2aad72e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e1e21cf) will **increase** coverage by `78.25%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #1302 +/- ##
===========================================
+ Coverage 0 78.25% +78.25%
===========================================
Files 0 15 +15
Lines 0 1761 +1761
===========================================
+ Hits 0 1378 +1378
- Misses 0 383 +383
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/1302?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/1302?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL3ByZXBhcmUuanM=) | `85.02% <100.00%> (ø)` | |
... and [14 files with indirect coverage changes](https://codecov.io/gh/apache/cordova-ios/pull/1302/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] quyenvsp commented on pull request #1302: fix(node-18): ATS URL Parsing
Posted by "quyenvsp (via GitHub)" <gi...@apache.org>.
quyenvsp commented on PR #1302:
URL: https://github.com/apache/cordova-ios/pull/1302#issuecomment-1517272650
Just note for people who has problem Invalid url
```
<allow-navigation href="*youtube*" />
```
should change to
```
<allow-navigation href="http:*youtube*" />
<allow-navigation href="https:*youtube*" />
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] NiklasMerz merged pull request #1302: fix(node-18): ATS URL Parsing
Posted by "NiklasMerz (via GitHub)" <gi...@apache.org>.
NiklasMerz merged PR #1302:
URL: https://github.com/apache/cordova-ios/pull/1302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org