[GitHub] [doris] morningman commented on a diff in pull request #13224: [fix](rowset) fix that rowset writer doesn't process the return value which may result in data loss

[GitBox <gi...@apache.org>]

morningman commented on code in PR #13224:
URL: https://github.com/apache/doris/pull/13224#discussion_r990808904


##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -173,7 +173,11 @@ OLAPStatus BetaRowsetWriter::flush_single_memtable(MemTable* memtable, int64_t*
 RowsetSharedPtr BetaRowsetWriter::build() {
     // TODO(lingbin): move to more better place, or in a CreateBlockBatch?
     for (auto& wblock : _wblocks) {

Review Comment:
   I think we should fix it in a more complete way, to return Status instead of nullptr, which is very error-prone.
   And use `RowsetSharedPtr` as an out parameter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org